Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure EnableThreadSafetyChecks for functional tests too #16006

Closed
Piedone opened this issue May 7, 2024 · 1 comment · Fixed by #16079
Closed

Configure EnableThreadSafetyChecks for functional tests too #16006

Piedone opened this issue May 7, 2024 · 1 comment · Fixed by #16079
Labels
enhancement Needs Unit Test(s) Unit Tests or Functional Tests are required
Milestone

Comments

@Piedone
Copy link
Member

Piedone commented May 7, 2024

Is your feature request related to a problem? Please describe.

The new YesSql option, EnableThreadSafetyChecks, is enabled for some integrations tests. This is good, because it'll make issues like #15794 and #15628 more apparent by directly failing the tests. However, this is also needed for functional tests for the same reason.

Describe the solution you'd like

Most possibly, we need to pass a parameter to the web app when running it here, and bind it to EnableThreadSafetyChecks out of the box. Then, we also need to update the default appsettings.json with an example (but it should still be off by default).

Describe alternatives you've considered

I thought about not binding the config by default, but then we'd need to do some testing-specific change in the codebase still.

@Piedone Piedone added enhancement Needs Unit Test(s) Unit Tests or Functional Tests are required labels May 7, 2024
@Piedone
Copy link
Member Author

Piedone commented May 7, 2024

Related: #12834.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs Unit Test(s) Unit Tests or Functional Tests are required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants