Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make YesSqlOptions configurable from configuration provider #16079

Merged
merged 10 commits into from
May 18, 2024
Merged

Make YesSqlOptions configurable from configuration provider #16079

merged 10 commits into from
May 18, 2024

Conversation

MikeAlhayek
Copy link
Member

Fix #16006

Piedone
Piedone requested changes May 17, 2024
View reviewed changes
src/OrchardCore.Cms.Web/appsettings.json Show resolved Hide resolved
.github/workflows/mac_unit_test_ci.yml Outdated Show resolved Hide resolved
.github/workflows/mac_unit_test_ci.yml Outdated Show resolved Hide resolved
@MikeAlhayek MikeAlhayek requested a review from Piedone May 17, 2024 17:03
@Piedone Piedone mentioned this pull request May 18, 2024
Closed
Piedone
Piedone approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was ready for another review :).

@Piedone Piedone merged commit 7827810 into main May 18, 2024
22 checks passed
@Piedone Piedone deleted the ma/EnableThreadSafetyChecks branch May 18, 2024 17:34
This was referenced Jun 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure EnableThreadSafetyChecks for functional tests too
2 participants
@MikeAlhayek @Piedone