Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchard Framework -> Orchard Core #11040

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Orchard Framework -> Orchard Core #11040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b76575
Orchard Framework -> Orchard Core
hishamco Jan 19, 2022
c77af9c
Fix functional test
hishamco Jan 19, 2022
f19e906
Address feedback
hishamco Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OrchardCore.Themes/TheTheme/Views/Home/Index.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class="message message-success">
<h4>@T["Welcome to the Orchard Framework, your site has been successfully set up."]</h4>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing while the Orchard Framework is a set of APIs that could be used in Orchard Core CMS and any other app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Orchard Core. You can drop the "the".

<h4>@T["Welcome to Orchard Core, your site has been successfully set up."]</h4>
</div>
2 changes: 1 addition & 1 deletion test/OrchardCore.Tests.Functional/cms-tests/cypress/integration/sass-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ describe('SaaS Recipe test', function () {

it('Displays the home page of the SaaS theme', function(){
cy.visit(`${tenant.prefix}`);
cy.get('h4').should('contain.text', 'Welcome to the Orchard Framework, your site has been successfully set up.');
cy.get('h4').should('contain.text', 'Welcome to Orchard Core, your site has been successfully set up.');
})

it('SaaS admin login should work', function(){
Expand Down