Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow - content for each task - allows looping through content items using a query or contentype #11799

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

PBMikeW
Copy link
Contributor

@PBMikeW PBMikeW commented Jun 2, 2022

Allows looping through content items either of a single type or using a query, many possible uses I.e. loop through form entries and insert into CRM. Update content item lists etc etc.

image
image

@PBMikeW PBMikeW requested a review from agriffard as a code owner June 2, 2022 23:49
@PBMikeW PBMikeW requested a review from Skrypt June 7, 2022 06:48
@PBMikeW PBMikeW marked this pull request as draft November 20, 2022 19:33
@PBMikeW PBMikeW changed the title Workflow - content for each task - allows looping through a single content type Workflow - content for each task - allows looping through content items using a query or contentype Nov 21, 2022
@PBMikeW
Copy link
Contributor Author

PBMikeW commented Nov 22, 2022

Refactored and query feature added. Works well and tested in our own production environment (Current use case is emailing file from endpoint per office in CMS).
@sebastienros comments resolved.

@PBMikeW PBMikeW marked this pull request as ready for review November 22, 2022 03:35
@PBMikeW PBMikeW requested review from sebastienros and Skrypt and removed request for agriffard, Skrypt and sebastienros November 22, 2022 03:35
@Piedone
Copy link
Member

Piedone commented Mar 13, 2024

@sebastienros @Skrypt do you want to get back to finish the review here?

@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

Please fix the build errors. Since then, OC moved from Json.NET to System.Text.Json.

Copy link
Contributor

github-actions bot commented Jun 9, 2024

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

@github-actions github-actions bot added the stale label Jun 9, 2024
@PBMikeW
Copy link
Contributor Author

PBMikeW commented Jun 10, 2024

I'll tidy this up early July.

@Piedone
Copy link
Member

Piedone commented Jun 10, 2024

Thank you!

@github-actions github-actions bot removed the stale label Jun 10, 2024
@PBMikeW
Copy link
Contributor Author

PBMikeW commented Jul 25, 2024

@sebastienros @Piedone - Looking at this two years on, should this be split to fit more with the other workflows. I.e. 1) RetrieveContentFromQuery and then have a dropdown for query type? It can then be processed by the foreach task. On the flip side to that, I do find the workflows overwhelming for people and iterating in the one task would be way simpler.

@Piedone
Copy link
Member

Piedone commented Jul 25, 2024

I think having a dropdown would be nicer than a textbox, yes. Also, yes, I'd imagine this working similarly to the For Each task, in that it'll execute the connected task for each item (like the Iterate path). I don't think it makes sense to have to loop this into For Each.

Copy link
Contributor

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek
Copy link
Member

for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment.

@PBMikeW PBMikeW marked this pull request as draft November 1, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants