-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow - content for each task - allows looping through content items using a query or contentype #11799
base: main
Are you sure you want to change the base?
Conversation
src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/ContentForEachTask.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/ContentForEachTask.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/ContentForEachTask.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Contents/Workflows/Activities/ContentForEachTask.cs
Outdated
Show resolved
Hide resolved
…d test failing by using service provider
Refactored and query feature added. Works well and tested in our own production environment (Current use case is emailing file from endpoint per office in CMS). |
@sebastienros @Skrypt do you want to get back to finish the review here? |
Please fix the build errors. Since then, OC moved from Json.NET to System.Text.Json. |
It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up. |
I'll tidy this up early July. |
Thank you! |
@sebastienros @Piedone - Looking at this two years on, should this be split to fit more with the other workflows. I.e. 1) RetrieveContentFromQuery and then have a dropdown for query type? It can then be processed by the foreach task. On the flip side to that, I do find the workflows overwhelming for people and iterating in the one task would be way simpler. |
I think having a dropdown would be nicer than a textbox, yes. Also, yes, I'd imagine this working similarly to the For Each task, in that it'll execute the connected task for each item (like the Iterate path). I don't think it makes sense to have to loop this into For Each. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment. |
Allows looping through content items either of a single type or using a query, many possible uses I.e. loop through form entries and insert into CRM. Update content item lists etc etc.