Remove ILuceneSearchQueryService from OrchardCore.Search.Lucene #12624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove it as requested.
It was doing no harm at all, to be honest.
@sebastienros I don't think it has to do with the renaming of the assembly either. It was decided and voted that we rename it and I've never said I would not rename it back if we were agreeing on that as a group. If there are issues with the Migration, as I said, I will fix them. But so far the issues are not about the feature itself but about Deployment plans which I fixed this week. This ILuceneSearchQueryService, I decided to not move it at all in the end because I wanted to keep as little change as possible in the OrchardCore.Search.Lucene module for people to migrate easily. It would have caused no issue at all if we would have kept it where it was in the OrchardCore.Search.Lucene module too but my mistake was to not remove the ISearchQueryService that I had copied in the OrchardCore.Search.Lucene.Abstraction module. Now, we did completely the opposite and I'm not saying it is wrong. It is what it should be.
@MikeAlhayek We merged in the Elasticsearch PR in the main branch because it needs to be tested by people. Sorry if it caused you issues but you can also wait for the releases to ensure it is stable first. This is what the main branch is for.
I will assess the other request in a different PR to remove the testing of Elasticsearch.