fix role update

[hyzx86]

fix : #13024

Planned to also fix #13035.

chrome_HV9oeSsdLF.mp4

[jtkech]

@hyzx86

Thanks for re-opening this PR but maybe I will open a new PR as I already started to work on it locally to check different things as per my comment #13024 (comment)

@MikeAlhayek maybe a different approach for example to not execute the RoleUpdater on each shell activation if possible, I think I will ask you some questions to confirm what was intended to be done.

Hmm, one question on the fly, yes in the controller, dynamic permissions was not taken into account, hmm maybe we need to take them into account also in the RoleUpdater, will see.

[MikeAlhayek]

@jtkech I in the RoleUpdater I think we have to call GetDefaultStereotypes() to group the permissions role this way we know which permissions should belong to Stereotype/role. If the grouped role is known to the current site, we then assign it. Once we assign a permission, we save the reference into RolesDocument.PermissionGroups this way we can know which permissions were auto assigned vs the assignments that were manually made "a user checking/unchecking" permissions.

In the Admin I agree we should not be using GetDefaultStereotypes()

We should be using the following as per your suggestions.

var permissionNames = new List<string>();
foreach (var permissionProvider in _permissionProviders)
{
    var permissions = await permissionProvider.GetPermissionsAsync();
    permissionNames.AddRange(permissions.Select(permission => permission.Name));
}

or

var allPermissions = await Task.WhenAll(_permissionProviders.Select(x => x.GetPermissionsAsync()));

[jtkech]

Even if here all GetPermissionsAsync() seem to be synchronous (using Task.FromResult), and in that case it would be useless, I never use Task.WhenAll() ;) Unless I'm sure all are thread safe, which is not the case e.g. with ISession.

So okay the other breaking change, as stated by @gvkries #13035 (comment), is that on an existing installation not having yet the permissions history, some permissions get back to some roles on startup.

[jtkech]

Okay I'm closing this one as I started to work on it on another branch #13040.

@hyzx86 @gvkries I will let you know when it will be ready to be tested.