Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix role update #13025

Closed
wants to merge 3 commits into from
Closed

fix role update #13025

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46b37af
fix role update
hyzx86 Jan 2, 2023
5e863ba
Update src/OrchardCore.Modules/OrchardCore.Roles/Controllers/AdminCon…
hyzx86 Jan 3, 2023
8b7374f
Update variable naming
hyzx86 Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/OrchardCore.Modules/OrchardCore.Roles/Controllers/AdminController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,8 @@ public async Task<IActionResult> EditPost(string id, string roleDescription)

rolesDocument.PermissionGroups.TryAdd(role.RoleName, new List<string>());

var permissionNames = _permissionProviders.SelectMany(x => x.GetDefaultStereotypes())
.SelectMany(y => y.Permissions ?? Enumerable.Empty<Permission>())
.Select(x => x.Name)
.ToList();
var installedPermissions = await GetInstalledPermissionsAsync();
var allPermissions = installedPermissions.SelectMany(x => x.Value).Select(x=>x.Name);
hyzx86 marked this conversation as resolved.
Show resolved Hide resolved

// Save
var rolePermissions = new List<RoleClaim>();
Expand All @@ -232,7 +230,7 @@ public async Task<IActionResult> EditPost(string id, string roleDescription)
permissionName = key.Substring("Checkbox.".Length);
}

if (!permissionNames.Contains(permissionName, StringComparer.OrdinalIgnoreCase))
if (!allPermissions.Contains(permissionName, StringComparer.OrdinalIgnoreCase))
{
// The request contains an invalid permission, let's ignore it
continue;
Expand Down