Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viktoriamagyar as a contributor for eventOrganizing #15036

Closed
wants to merge 2 commits into from

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @viktoriamagyar as a contributor for eventOrganizing.

This was requested by Piedone in this comment

[skip ci]

Copy link
Contributor Author

@dotnet-policy-service[bot]

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@Piedone Piedone changed the title add viktoriamagyar as a contributor for eventOrganizing Add viktoriamagyar as a contributor for eventOrganizing Jan 10, 2024
Copy link
Contributor Author

@dotnet-policy-service[bot]

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@Piedone
Copy link
Member

Piedone commented Jan 10, 2024

I'm not sure what to do here: microsoft/ContributorLicenseAgreement#161

@Skrypt
Copy link
Contributor

Skrypt commented Jan 10, 2024

Make her submit a PR so that she signs the CLA?

@Piedone
Copy link
Member

Piedone commented Jan 10, 2024

It's the bot that would need to sign a CLA.

@Skrypt
Copy link
Contributor

Skrypt commented Jan 10, 2024

It is preventing to submit anything here because she never signed the CLA. The bot cannot do it for her, it would not be legal.

@Piedone
Copy link
Member

Piedone commented Jan 10, 2024

This PR is a contribution by the @allcontributors bot, not Viktória. Who the @dotnet-policy-service asks to sign a CLA is the bot. Since this won't happen, of course, I opened the issue. But I'll close this and add the change myself under #15037.

Copy link
Contributor Author

@Piedone

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@Piedone Piedone closed this Jan 10, 2024
@Skrypt
Copy link
Contributor

Skrypt commented Jan 10, 2024

Yeah you tried to use a bot that cannot add Victoria as a contributor because "legally" she is not because she never signed the CLA agreement.

@Piedone
Copy link
Member

Piedone commented Jan 10, 2024

That's not the case :). The policy bots knows nothing about Viktória contributing, and it doesn't collaborate with the All Contributors bot either. The "contribution" here is the code in this PR. That's by the All Contributors bot. The policy bot thus asked the other bot to sign the CLA.

Don't worry about it.

@Skrypt
Copy link
Contributor

Skrypt commented Jan 10, 2024

hmm ok, I think you are right. It's the @ //all-contributors that would need to sign the CLA.

@Piedone
Copy link
Member

Piedone commented May 14, 2024

@all-contributors please add @LombiqBot for code.

I'm testing OrchardCMS/.github@64da691.

Copy link
Contributor Author

@Piedone

I've put up a pull request to add @LombiqBot! 🎉

@Piedone
Copy link
Member

Piedone commented May 14, 2024

And it worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants