Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contributors docs (Lombiq Technologies: OCORE-138) #15037

Merged
merged 24 commits into from
Jan 13, 2024

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Jan 10, 2024

Fixes #14586.

  • Clarified how to use the All Contributors bot.
  • Added @viktoriamagyar as a test, who was the main organizer of Orchard Harvest 2023.
  • Simplified the root Readme a bit, to clarify where to start if you want to use OC and if you want to contribute and otherwise what to look for. Previously, you were first pointed to clone the repo, which is not what you want if you just want to consume OC. Also removed the link to the outdated Roadmap, see Disable Wiki #15061.
  • Moving Contributors.md to the docs site.
  • Adding a cool map that shows where our contributors come from.

@Piedone
Copy link
Member Author

Piedone commented Jan 10, 2024

@all-contributors please add @viktoriamagyar for eventOrganizing

Copy link
Contributor

@Piedone

@viktoriamagyar already contributed before to eventOrganizing

@@ -0,0 +1,19 @@
name: Update Contributor Map
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will only work in main. I generated the initial map in a different repo.

},
{
"login": "viktoriamagyar",
"name": "Viktória Magyar",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did she contribute? I prefer to use the bot after merging this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, she was the main organizer of Orchard Harvest 2023. The bot can be used, what I did under #15036, but it has policy bot issues under its own PRs so I included that change here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, she was the main organizer of Orchard Harvest 2023

Sure I never forgot that, but we commonly added contributors if they contribute to the code or docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we commonly do that, but the point of All Contributors is specifically to "Recognize All Contributors
Including those that don't push code". That's why they also have the eventOrganizing category that I used.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Piedone
Copy link
Member Author

Piedone commented Jan 11, 2024

I'm making the root Readme a bit easier to digest still, stay tuned.

@Piedone Piedone requested a review from hishamco January 11, 2024 15:31
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
src/docs/community/README.md Show resolved Hide resolved
src/docs/community/README.md Show resolved Hide resolved
@Piedone Piedone requested a review from hishamco January 11, 2024 22:27
@agriffard agriffard merged commit 09d5a59 into OrchardCMS:main Jan 13, 2024
3 checks passed
@agriffard
Copy link
Member

Wiki disabled in the Settings.

@agriffard
Copy link
Member

Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key))!
on https://docs.orchardcore.net/en/latest/docs/community/contributors/

Is the Emoji key expected like that?

@Piedone
Copy link
Member Author

Piedone commented Jan 13, 2024

If you mean why is that link there (it renders for me), then it wad previously also there, but I guess to help people understand who contributed what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate using Contributors-Readme-Action to maintain Contributors.md
3 participants