-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Contributors docs (Lombiq Technologies: OCORE-138) #15037
Conversation
@all-contributors please add @viktoriamagyar for eventOrganizing |
@viktoriamagyar already contributed before to eventOrganizing |
@@ -0,0 +1,19 @@ | |||
name: Update Contributor Map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will only work in main
. I generated the initial map in a different repo.
}, | ||
{ | ||
"login": "viktoriamagyar", | ||
"name": "Viktória Magyar", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did she contribute? I prefer to use the bot after merging this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, she was the main organizer of Orchard Harvest 2023. The bot can be used, what I did under #15036, but it has policy bot issues under its own PRs so I included that change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, she was the main organizer of Orchard Harvest 2023
Sure I never forgot that, but we commonly added contributors if they contribute to the code or docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we commonly do that, but the point of All Contributors is specifically to "Recognize All Contributors
Including those that don't push code". That's why they also have the eventOrganizing
category that I used.
I'm making the root Readme a bit easier to digest still, stay tuned. |
Wiki disabled in the Settings. |
Is the |
If you mean why is that link there (it renders for me), then it wad previously also there, but I guess to help people understand who contributed what. |
Fixes #14586.