Javascript error when there are no deployment steps #15306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
requested changes
Feb 11, 2024
Piedone
approved these changes
Feb 12, 2024
|
When you're done, please re-request review, so reviewers can get notified:
In this case, doing this for Mike remains :). |
|
@lampersky I am looking at this PR as it reflect another problem we saw with one of yours. It appears you don't know about the gulp pipeline we use to generate /wwwroot and minimized files and you updated these by hand which introduced errors. For instance the wwwroot version has the opposite test, and the minimized version was forgotten altogether. We'll fix it in main but it's important you understand how to get this command running when you update a javascript file from an Assets folder. https://docs.orchardcore.net/en/latest/docs/guides/gulp-pipeline/ |
Merged
|
@lampersky the issue was fix by #15387 |
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15301
/cc: @Piedone