Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix steporder.js #15387

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix steporder.js #15387

merged 3 commits into from
Feb 21, 2024

Conversation

MikeAlhayek
Copy link
Member

No description provided.

@sebastienros
Copy link
Member

Have you tried it? It's possible that the correct fix was done in the wwwroot manually, I just want to be sure that's what it was supposed to do.

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Feb 21, 2024

that condition was added to avoid a js exception when trying to sort objects that does not exists in the DOM.

I made the update to the assets file so then we gulp creates the final files, it would use the correct logic.

@MikeAlhayek
Copy link
Member Author

this is the correct logic "already in main"

@sebastienros
Copy link
Member

I'll let you merge Bootstrap and this one yourself then because there will be conflicts: the 3 files impacted need to match. Might be easier to reapply gulp here once BS is merged

@MikeAlhayek MikeAlhayek enabled auto-merge (squash) February 21, 2024 23:23
@MikeAlhayek MikeAlhayek merged commit a570f55 into main Feb 21, 2024
5 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/steporder branch February 21, 2024 23:29
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants