-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Content Item ApiController.cs endpoints documentation #15512
Conversation
work in progress on adding ApiController.cs info
It's a community project, I remember we mentioned many open-source libraries in the CREDITS section. so you can refer to it if no one has an objection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
When addressing review feedback, please adhere to the following:
|
Any news, @MarGraz? |
@Piedone I will work on the changes during this week. |
@coderabbitai review |
WalkthroughThe recent documentation update provides an extensive overview of utilizing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
Out of diff range and nitpick comments (5)
src/docs/reference/modules/Contents/README.md (5)
Line range hint
1-1
: Add a space after the period in the first sentence for better readability.
Line range hint
13-13
: The description forCreatedUtc
andOwner
incorrectly states "The HTML content in the body." This should describe the actual purpose of these properties.- | `CreatedUtc` | `DateTime` | The HTML content in the body. | - | `Owner` | `string` | The HTML content in the body. | + | `CreatedUtc` | `DateTime` | The UTC timestamp when the content item was created. | + | `Owner` | `string` | The username of the content item owner. |
Line range hint
46-46
: The abbreviation "id" should be capitalized to "ID" for consistency and to follow common conventions.- ### Loading from a content item id + ### Loading from a content item ID
Line range hint
75-75
: Consider using a hyphen in "well known" to form the compound adjective "well-known."- The `console_log` liquid filter can be used to dump data from well known properties, or objects serializable to json, to the browser console. + The `console_log` liquid filter can be used to dump data from well-known properties, or objects serializable to json, to the browser console.
134-134
: Ensure there is a space after the period in the sentence for better readability.
These seem like sensible suggestions. |
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
Out of diff range and nitpick comments (1)
src/docs/reference/modules/Contents/README.md (1)
Line range hint
1-1
: Add a space after the period to separate the sentences for better readability.- # Contents (`OrchardCore.Contents`) This module provides Content Management services. + # Contents (`OrchardCore.Contents`) This module provides Content Management services.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
Out of diff range and nitpick comments (2)
src/docs/reference/modules/Contents/README.md (2)
Line range hint
1-1
: Add a space after the period in the first sentence for better readability.
Line range hint
13-13
: The description forCreatedUtc
andOwner
incorrectly states "The HTML content in the body." This should describe the actual purpose of these properties.- | `CreatedUtc` | `DateTime` | The HTML content in the body. | - | `Owner` | `string` | The HTML content in the body. | + | `CreatedUtc` | `DateTime` | The UTC timestamp when the content item was created. | + | `Owner` | `string` | The username of the content item owner. |
Co-authored-by: Zoltán Lehóczky <[email protected]>
Added suggested changes
Updated the API table descriptions
Updated a wrong info in the parameters table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply code suggestions directly so the reviewer doesn't have to eyeball the changes. These resolve themselves after applying them, that's fine. Naturally though, don't resolve comments with code suggestions that you haven't actually applied.
But please don't resolve other conversations so it's easier to track for the reviewer. Then, the reviewer will resolve them.
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
Co-authored-by: Zoltán Lehóczky <[email protected]>
…braries" paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved all the comments, except one, asked what should I do here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piedone all the changes are applied, tests are passed
Co-authored-by: Hisham Bin Ateya <[email protected]>
Co-authored-by: Hisham Bin Ateya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
As discussed here, I'm asking for your assistance @Piedone, to review the documentation section I have added about the Content Item API Controller.
Additionally, it would be good to include a link to the Swagger module developed by @hishamco. But I'm not sure if I can add a link to an unofficial swagger module.
Thank you