Suppress incorrect "CA1822:Mark members as static" analyzer violation in ShapeProxyBenchmark (Lombiq Technologies: OCORE-156) #15707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in ShapeProxyBenchmark
Piedone
commented
Apr 9, 2024
Comment on lines
+23
to
+26
| [SuppressMessage( | ||
| "Performance", | ||
| "CA1822:Mark members as static", | ||
| Justification = "BenchmarkDotNet needs all benchmark methods to be instance-level.")] |
There was a problem hiding this comment.
I didn't add this to the whole project in the end, because these are best when they're as narrow as possible, and there's no other instance of this in the project.
Piedone
changed the title
hishamco
approved these changes
Apr 9, 2024
Skrypt
approved these changes
Apr 9, 2024
This was referenced Apr 10, 2024
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing warnings like these:
Started from here: #15696 (review)