Treat warnings as errors during CI build (Lombiq Technologies: OCORE-157) #15764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
Apr 19, 2024
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #15707 we have no build warnings in CI. To ensure that this stays this way, this PR makes the CI builds fail if you leave any build warnings in the code. (Locally you can still prototype with warnings.)
This is the very first rudimentary step on the way to #7950.
I attempted this first under #15719, but then it turned out that we do have 900 build warnings. Somehow now we only have one though.
You can test this locally with:
--no-incrementalmakes sure you run it as it were a fresh clone.