Convert v1.9 to v2.0 #15938
Merged
Convert v1.9 to v2.0 #15938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe transition from Orchard Core version 1.9.0 to 2.0.0 signifies significant improvements and changes. Key updates include the version prefix alteration, detailed upgrade instructions, and the removal of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Piedone
reviewed
May 1, 2024
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (4)
src/docs/releases/2.0.0.md (4)
Line range hint
13-13: Add spaces between sentences for better readability.- Instead, we have transitioned to utilize `System.Text.Json` due to its enhanced performance capabilities. To ensure compatibility with `System.Text.Json` during the serialization or deserialization of objects, the following steps need to be undertaken: + Instead, we have transitioned to utilize `System.Text.Json` due to its enhanced performance capabilities. To ensure compatibility with `System.Text.Json` during the serialization or deserialization of objects, the following steps need to be undertaken:
Line range hint
29-29: Correct the typo for accuracy.- custom admin menu nodep like this: + custom admin menu node like this:
Line range hint
88-88: Consider adding a comma for clarity.- The `OrchardCore_Twitter` key continues to work but will be deprecated in a future release. + The `OrchardCore_Twitter` key continues to work, but will be deprecated in a future release.
Line range hint
199-199: Add a space after the period for better readability.- If you want to continue to index `.PDF` file you'll need to enable the `OrchardCore.Media.Indexing.Pdf` feature. + If you want to continue to index `.PDF` file, you'll need to enable the `OrchardCore.Media.Indexing.Pdf` feature.
Co-authored-by: Zoltán Lehóczky <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (5)
src/docs/releases/2.0.0.md (5)
Line range hint
13-13: Add a space after the period for better readability.- The utilization of [Newtonsoft.Json](https://www.nuget.org/packages/Newtonsoft.Json) has been discontinued in both **YesSql** and **OrchardCore**. Instead, we have transitioned to utilize `System.Text.Json` due to its enhanced performance capabilities. + The utilization of [Newtonsoft.Json](https://www.nuget.org/packages/Newtonsoft.Json) has been discontinued in both **YesSql** and **OrchardCore**. Instead, we have transitioned to utilize `System.Text.Json` due to its enhanced performance capabilities.
Line range hint
29-29: The word "nodep" seems to be a typo. Consider correcting it to "node".- services.AddSingleton<IAdminNodeProviderFactory>(new AdminNodeProviderFactory<PlaceholderAdminNode>()); + services.AddSingleton<IAdminNodeProviderFactory>(new AdminNodeProviderFactory<PlaceholderAdminNode>());
Line range hint
43-43: The term "sub-classes" is typically written as one word: "subclasses".- Any serializable object that contains a polymorphic property (a base type that can contain sub-classes instances) needs to register all possible sub-classes this way: + Any serializable object that contains a polymorphic property (a base type that can contain subclasses instances) needs to register all possible subclasses this way:
Line range hint
199-199: Add a space after the period for better readability.- Previously, `.pdf` files were automatically indexed in the search providers (Elasticsearch, Lucene or Azure AI Search). Now, if you want to continue to index `.PDF` file you'll need to enable the `OrchardCore.Media.Indexing.Pdf` feature. + Previously, `.pdf` files were automatically indexed in the search providers (Elasticsearch, Lucene or Azure AI Search). Now, if you want to continue to index `.PDF` file you'll need to enable the `OrchardCore.Media.Indexing.Pdf` feature.
Line range hint
335-335: Consider using a comma before 'so' to connect two independent clauses.- This means you don't have to define these admin routes in your module's `Startup` class anymore, but that option is still available and supported. + This means you don't have to define these admin routes in your module's `Startup` class anymore, but that option is still available and supported, so the names can be unique for each action.
|
@Piedone look at that failing test. This should not fail since we purposely not add the latest release notes to the navbar. Do you want to fix the Workflow or should be add it to the navbar? |
|
Passed! Thank you |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
Piedone
approved these changes
May 1, 2024
…rs (#15875) Co-authored-by: Zoltán Lehóczky <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Mike Alhayek <[email protected]>
…Manager.UpdateAsync(IEnumerable<string>) (#15909) Co-authored-by: Zoltán Lehóczky <[email protected]>
|
|
||
| Release date: Not yet released | ||
|
|
||
| ## Upgrade Instructions | ||
|
|
||
| Before upgrading to Orchard Core 2.0, you should first upgrade to 1.8, address any warnings, and only then upgrade to 2.0. Be sure to review the list of breaking changes documented below to ensure a seamless transition. |
There was a problem hiding this comment.
Add a space after the period for better readability.
- Before upgrading to Orchard Core 2.0, you should first upgrade to 1.8, address any warnings, and only then upgrade to 2.0. Be sure to review the list of breaking changes documented below to ensure a seamless transition.
+ Before upgrading to Orchard Core 2.0, you should first upgrade to 1.8, address any warnings, and only then upgrade to 2.0. Be sure to review the list of breaking changes documented below to ensure a seamless transition. Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| Before upgrading to Orchard Core 2.0, you should first upgrade to 1.8, address any warnings, and only then upgrade to 2.0. Be sure to review the list of breaking changes documented below to ensure a seamless transition. | |
| Before upgrading to Orchard Core 2.0, you should first upgrade to 1.8, address any warnings, and only then upgrade to 2.0. Be sure to review the list of breaking changes documented below to ensure a seamless transition. |
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15892
Summary by CodeRabbit
IShellReleaseManagerfor consistency.