OC project templates should show net8.0 only #16048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piedone
requested changes
May 13, 2024
...tTemplates/content/OrchardCore.Templates.Cms.Module/.template.config.src/dotnetcli.host.json
Show resolved
Hide resolved
Piedone
changed the title
|
@Piedone anything to add here or shall we merge this I started to clean the remaining of my PRs :) |
Piedone
requested changes
May 18, 2024
|
Feel free to merge if you're OK with my suggestion after applying it. |
|
Again, it's annoying when the workflow triggered on review before commit anything |
Co-authored-by: Zoltán Lehóczky <[email protected]>
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on the project templates, I chose 1.8.3 I just noticed that the previous .NET framework shows up which is wrong .NET 8.0 should be the only option that I can pick