Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OrchardCore.OpenId to explicitly reference Microsoft.IdentityModel.Protocols.OpenIdConnect #16057

Merged
merged 2 commits into from
May 15, 2024

Conversation

kevinchalet
Copy link
Member

@kevinchalet kevinchalet commented May 14, 2024

The OpenID module uses both the MSFT OIDC handler and OpenIddict and both projects depend on IdentityModel. Unfortunately, while OpenIddict references a recent version (7.5.1), the MSFT OIDC handler package still references an old version (7.1.2):

image

Having mismatched versions of the System.IdentityModel.* or Microsoft.IdentityModel.* packages is explicitly NOT supported by the Wilson team and has recently caused a lot of pain due to very-hard-to-find bugs:

This PR fixes that by explicitly referencing Microsoft.IdentityModel.Protocols.OpenIdConnect to ensure it uses the same IdentityModel version as OpenIddict:

image

(I strongly recommend including this change in 2.0, hence the explicit 2.0 milestone 🤣)

@kevinchalet kevinchalet added OpenId dependencies Pull requests that update a dependency file labels May 14, 2024
@kevinchalet kevinchalet added this to the 2.0 milestone May 14, 2024
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation :).

src/OrchardCore.Build/Dependencies.props Show resolved Hide resolved
…nect is explicitly listed in Dependencies.props
@kevinchalet kevinchalet merged commit 8dca5ad into OrchardCMS:main May 15, 2024
70 checks passed
@kevinchalet kevinchalet deleted the identitymodel branch May 15, 2024 20:21
@kevinchalet
Copy link
Member Author

Thanks for the review, @Piedone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file OpenId
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants