Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OrchardCore.OpenId to explicitly reference Microsoft.IdentityModel.Protocols.OpenIdConnect #16057

Merged
merged 2 commits into from
May 15, 2024
Merged

Update OrchardCore.OpenId to explicitly reference Microsoft.IdentityModel.Protocols.OpenIdConnect #16057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33ed7e
Update OrchardCore.OpenId to explicitly reference Microsoft.IdentityM…
kevinchalet May 14, 2024
939906a
Add a note indicating why Microsoft.IdentityModel.Protocols.OpenIdCon…
kevinchalet May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/OrchardCore.Build/Dependencies.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@
<PackageManagement Include="Microsoft.Extensions.Azure" Version="1.7.3" />
<PackageManagement Include="Microsoft.Extensions.Http.Resilience" Version="8.4.0" />
<PackageManagement Include="Microsoft.Identity.Web" Version="2.18.1" />

<!--
Important: the version of the Microsoft.IdentityModel.Protocols.OpenIdConnect package MUST
match the IdentityModel version transitively referenced by OpenIddict to ensure we don't
accidentally end up referencing inconsistent versions (which is not supported by IM).

See https://github.com/OrchardCMS/OrchardCore/pull/16057 for more information.
-->

<PackageManagement Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="7.5.1" />
Piedone marked this conversation as resolved.
Show resolved Hide resolved
<PackageManagement Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageManagement Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageManagement Include="MimeKit" Version="4.5.0" />
Expand Down
1 change: 1 addition & 0 deletions src/OrchardCore.Modules/OrchardCore.OpenId/OrchardCore.OpenId.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" />
<PackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" />
<PackageReference Include="OpenIddict.Server.AspNetCore" />
<PackageReference Include="OpenIddict.Server.DataProtection" />
<PackageReference Include="OpenIddict.Validation.AspNetCore" />
Expand Down