Prevent Functional Tests - All Databases triggering on PR comments (Lombiq Technologies: OCORE-171) #16097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
May 27, 2024
|
It worked. Let's see if it indeed doesn't trigger after this comment. |
|
It didn't, looks good. |
hishamco
requested changes
May 27, 2024
| @@ -21,6 +21,14 @@ env: | |||
| jobs: | |||
| test_functional_mvc: | |||
| name: Functional Tests - MVC | |||
| # These conditions are needed because the workflow triggers on individual PR comments too, see | |||
There was a problem hiding this comment.
Suggested change
| # These conditions are needed because the workflow triggers on individual PR comments too, see | |
| # These conditions are needed because the workflow triggers individual PR comments too, see |
There was a problem hiding this comment.
It doesn't trigger comments ("trigger comments" ~= "creates comments") but is triggered by comments being added, hence the GitHub terminology "on".
hishamco
approved these changes
May 27, 2024
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a GitHub Actions bug, see https://github.com/orgs/community/discussions/124396, but this works around it.
Let's check what happens if you approve this PR!