Fix show password button on the login screen (Lombiq Technologies: OCORE-172) #16098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
reviewed
May 19, 2024
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| <script at="Foot"> | |||
| togglePassword = document.querySelector('#togglePassword'); | |||
| password = document.querySelector('#Password'); | |||
| password = document.querySelector('#@Html.IdFor(m => m.Password)'); | |||
There was a problem hiding this comment.
Please add the directive let before password and togglePassword. These are local variables
There was a problem hiding this comment.
What are the difference except the intellisense, both have "#Password" value
There was a problem hiding this comment.
The old hard-coded ID that the script depended on was Password but the new one generated by asp-for="Password" is LoginForm_Password. This is why the script was broken.
Piedone
changed the title
MikeAlhayek
approved these changes
May 19, 2024
hishamco
approved these changes
May 19, 2024
I think that can remain; It's a single-use element that doesn't have a corresponding member in the view model. Thanks both! |
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked for similar issues but this seems to be the only one.
This is a regression post-1.8.