Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casting during workflow instance restart #16139

Merged
merged 4 commits into from
May 23, 2024
Merged

Fix casting during workflow instance restart #16139

merged 4 commits into from
May 23, 2024

Conversation

MikeAlhayek
Copy link
Member

Fix #15411

@MikeAlhayek
Copy link
Member Author

/cc @BenedekFarkas

BenedekFarkas
BenedekFarkas requested changes May 23, 2024
View reviewed changes
Copy link
Member

@BenedekFarkas BenedekFarkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike, I can confirm the change is working as expected! Posted a minor change suggestion.

src/OrchardCore/OrchardCore.Workflows.Abstractions/Helpers/DictionaryExtensions.cs Outdated Show resolved Hide resolved
@MikeAlhayek MikeAlhayek merged commit 9a8aa1c into main May 23, 2024
6 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/fix-workflow-restart branch May 23, 2024 15:31
@sebastienros
Copy link
Member

Workflow activities seem to pass a ContentItem around using a well-known constant.

It seems that previously (with Newtonsoft JSON) this item was an IContent and now it's a Dictionary<string, object>. We should understand why this change happened and if instead we should ensure that the object that flows is of IContent`, by doing the correct deserialization once.

138. content = workflowContext.Input.GetValue<IContent>(ContentEventConstants.ContentItemInputKey)

This was referenced Jun 1, 2024
Closed
Open
@MikeAlhayek MikeAlhayek mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenedekFarkas BenedekFarkas BenedekFarkas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restarting instance of a workflow starting with the Content Created event fails with InvalidCastException
3 participants
@MikeAlhayek @sebastienros @BenedekFarkas