Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Central Package Management #16235

Merged
merged 10 commits into from
Jun 9, 2024
Merged

Migrate to Central Package Management #16235

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06b02b3
Separate TargetFramework definition from package version info
tmat Jun 4, 2024
1d5da95
Move TargetFrameworks improt to root Directory.Build.props
tmat Jun 4, 2024
e678d0f
Migrate to Central Package Management
tmat Jun 4, 2024
c761690
Disable transitive pinning to minimize impact
tmat Jun 5, 2024
81e8a85
Merge branch 'main' into CPM
MikeAlhayek Jun 6, 2024
fad3476
spacing
MikeAlhayek Jun 6, 2024
6030fc0
Update src/OrchardCore.Build/Dependencies.AspNetCore.props
MikeAlhayek Jun 6, 2024
c434644
Move versions to Directory.Packages.props
sebastienros Jun 8, 2024
8867aa6
Fix TargetFrameworks.props import
sebastienros Jun 8, 2024
97dd3c9
Merge Dependencies.AspNetCore.props
sebastienros Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ build/
app.publish/
[Bb]in/
[Oo]bj/
*.binlog

# Enable "build/" folder in the NuGet Packages folder since NuGet packages use it for MSBuild targets
!packages/*/build/
Expand Down
1 change: 1 addition & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<Project>
<Import Project="src\OrchardCore.Build\TargetFrameworks.props" />

<PropertyGroup>
<!-- https://aka.ms/vs-build-acceleration -->
Expand Down
6 changes: 6 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<Import Project="src\OrchardCore.Build\Dependencies.props" />
</Project>
MikeAlhayek marked this conversation as resolved.
Show resolved Hide resolved
39 changes: 10 additions & 29 deletions src/OrchardCore.Build/Dependencies.AspNetCore.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,4 @@
<Project>

<!-- Default TFMs to use when building and packaging -->
<PropertyGroup>

<!-- TFM used when coding in Visual Studio and when creating templates -->
<!-- All 'template.json' should provide a 'choice' for the default TFM -->
<DefaultTargetFramework>net8.0</DefaultTargetFramework>

<!-- TFMs used to build the abstractions and modules, by convention the default TFM is at the first position -->
<!-- In a cross-targeting build, some assets are only copied on the first TFM, by convention the default TFM -->
<CommonTargetFrameworks Condition="'$(CommonTargetFrameworks)' == ''">net8.0</CommonTargetFrameworks>
</PropertyGroup>

<!-- Detect if the solution is opened in VS to limit the TFMs that are analyzed by Roslyn for performance reasons -->
<PropertyGroup Condition="'$(BuildingInsideVisualStudio)' == 'true' or '$(BuildingByReSharper)' == 'true'">
<CommonTargetFrameworks>$(DefaultTargetFramework)</CommonTargetFrameworks>
</PropertyGroup>

<!-- These versions are used for the NuGet packages that are dependent on the current TFM -->
<!-- Versions are preset for the default TFM (there may be no TFM in an evaluation phase) -->
<PropertyGroup>
Expand All @@ -33,21 +15,20 @@

<!-- 'Microsoft.AspNetCore' packages that are not included in the ASP.NET Core shared framework -->
<ItemGroup>
<PackageManagement Include="Microsoft.AspNetCore.Authentication.Facebook" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.Authentication.Google" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.Authentication.MicrosoftAccount" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.Authentication.Twitter" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.DataProtection.StackExchangeRedis" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(AspNetCorePackagesVersion)" />
<PackageManagement Include="Microsoft.AspNetCore.Owin" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.Facebook" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.Google" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.MicrosoftAccount" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.OpenIdConnect" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.Twitter" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.DataProtection.StackExchangeRedis" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="$(AspNetCorePackagesVersion)" />
<PackageVersion Include="Microsoft.AspNetCore.Owin" Version="$(AspNetCorePackagesVersion)" />
</ItemGroup>

<!-- 'Microsoft.Extensions' packages that are not included in the ASP.NET Core shared framework -->
<ItemGroup>
<PackageManagement Include="Microsoft.Extensions.Caching.StackExchangeRedis" Version="$(MicrosoftExtensionsPackagesVersion)" />
<PackageManagement Include="Microsoft.Extensions.Http.Resilience" Version="$(MicrosoftExtensionsPackagesVersion)" />
tmat marked this conversation as resolved.
Show resolved Hide resolved
<PackageVersion Include="Microsoft.Extensions.Caching.StackExchangeRedis" Version="$(MicrosoftExtensionsPackagesVersion)" />
MikeAlhayek marked this conversation as resolved.
Show resolved Hide resolved
</ItemGroup>

</Project>
142 changes: 71 additions & 71 deletions src/OrchardCore.Build/Dependencies.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,40 +8,40 @@
</PropertyGroup>

<ItemGroup>
<PackageManagement Include="AngleSharp" Version="1.1.2" />
<PackageManagement Include="AWSSDK.S3" Version="3.7.104.11" />
<PackageManagement Include="AWSSDK.Extensions.NETCore.Setup" Version="3.7.7" />
<PackageManagement Include="AWSSDK.SecurityToken" Version="3.7.101.60" />
<PackageManagement Include="Azure.Communication.Email" Version="1.0.1" />
<PackageManagement Include="Azure.Extensions.AspNetCore.Configuration.Secrets" Version="1.3.1" />
<PackageManagement Include="Azure.Extensions.AspNetCore.DataProtection.Blobs" Version="1.3.4" />
<PackageManagement Include="Azure.Identity" Version="1.11.3" />
<PackageManagement Include="Azure.Search.Documents" Version="11.5.1" />
<PackageManagement Include="Azure.Storage.Blobs" Version="12.20.0" />
<PackageManagement Include="BenchmarkDotNet" Version="0.13.12" />
<PackageManagement Include="Castle.Core" Version="5.1.1" />
<PackageManagement Include="DocumentFormat.OpenXml" Version="3.0.2" />
<PackageManagement Include="Fluid.Core" Version="2.10.0" />
<PackageManagement Include="GraphQL" Version="7.8.0" />
<PackageManagement Include="GraphQL.DataLoader" Version="7.8.0" />
<PackageManagement Include="GraphQL.MicrosoftDI" Version="7.8.0" />
<PackageManagement Include="GraphQL.SystemTextJson" Version="7.8.0" />
<PackageManagement Include="Jint" Version="3.1.2" />
<PackageManagement Include="JsonPath.Net" Version="1.1.0" />
<PackageManagement Include="HtmlSanitizer" Version="8.1.860-beta" />
<PackageManagement Include="Irony" Version="1.5.1" />
<PackageManagement Include="libphonenumber-csharp" Version="8.13.37" />
<PackageManagement Include="Lorem.Universal.NET" Version="4.0.80" />
<PackageManagement Include="Lucene.Net" Version="4.8.0-beta00016" />
<PackageManagement Include="Lucene.Net.Analysis.Common" Version="4.8.0-beta00016" />
<PackageManagement Include="Lucene.Net.QueryParser" Version="4.8.0-beta00016" />
<PackageManagement Include="Lucene.Net.Spatial" Version="4.8.0-beta00016" />
<PackageManagement Include="MailKit" Version="4.6.0" />
<PackageManagement Include="Markdig" Version="0.36.2" />
<PackageManagement Include="MessagePack" Version="2.2.60" />
<PackageManagement Include="Microsoft.Extensions.Azure" Version="1.7.3" />
<PackageManagement Include="Microsoft.Extensions.Http.Resilience" Version="8.5.0" />
<PackageManagement Include="Microsoft.Identity.Web" Version="2.19.0" />
<PackageVersion Include="AngleSharp" Version="1.1.2" />
<PackageVersion Include="AWSSDK.S3" Version="3.7.104.11" />
<PackageVersion Include="AWSSDK.Extensions.NETCore.Setup" Version="3.7.7" />
<PackageVersion Include="AWSSDK.SecurityToken" Version="3.7.101.60" />
<PackageVersion Include="Azure.Communication.Email" Version="1.0.1" />
<PackageVersion Include="Azure.Extensions.AspNetCore.Configuration.Secrets" Version="1.3.1" />
<PackageVersion Include="Azure.Extensions.AspNetCore.DataProtection.Blobs" Version="1.3.4" />
<PackageVersion Include="Azure.Identity" Version="1.11.3" />
<PackageVersion Include="Azure.Search.Documents" Version="11.5.1" />
<PackageVersion Include="Azure.Storage.Blobs" Version="12.20.0" />
<PackageVersion Include="BenchmarkDotNet" Version="0.13.12" />
<PackageVersion Include="Castle.Core" Version="5.1.1" />
<PackageVersion Include="DocumentFormat.OpenXml" Version="3.0.2" />
<PackageVersion Include="Fluid.Core" Version="2.10.0" />
<PackageVersion Include="GraphQL" Version="7.8.0" />
<PackageVersion Include="GraphQL.DataLoader" Version="7.8.0" />
<PackageVersion Include="GraphQL.MicrosoftDI" Version="7.8.0" />
<PackageVersion Include="GraphQL.SystemTextJson" Version="7.8.0" />
<PackageVersion Include="Jint" Version="3.1.2" />
<PackageVersion Include="JsonPath.Net" Version="1.1.0" />
<PackageVersion Include="HtmlSanitizer" Version="8.1.860-beta" />
<PackageVersion Include="Irony" Version="1.5.1" />
<PackageVersion Include="libphonenumber-csharp" Version="8.13.37" />
<PackageVersion Include="Lorem.Universal.NET" Version="4.0.80" />
<PackageVersion Include="Lucene.Net" Version="4.8.0-beta00016" />
<PackageVersion Include="Lucene.Net.Analysis.Common" Version="4.8.0-beta00016" />
<PackageVersion Include="Lucene.Net.QueryParser" Version="4.8.0-beta00016" />
<PackageVersion Include="Lucene.Net.Spatial" Version="4.8.0-beta00016" />
<PackageVersion Include="MailKit" Version="4.6.0" />
<PackageVersion Include="Markdig" Version="0.36.2" />
<PackageVersion Include="MessagePack" Version="2.2.60" />
<PackageVersion Include="Microsoft.Extensions.Azure" Version="1.7.3" />
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="8.5.0" />
<PackageVersion Include="Microsoft.Identity.Web" Version="2.19.0" />

<!--
Important: the version of the Microsoft.IdentityModel.Protocols.OpenIdConnect package MUST
Expand All @@ -51,42 +51,42 @@
See https://github.com/OrchardCMS/OrchardCore/pull/16057 for more information.
-->

<PackageManagement Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="7.5.1" />
<PackageManagement Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageManagement Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageManagement Include="MimeKit" Version="4.6.0" />
<PackageManagement Include="MiniProfiler.AspNetCore.Mvc" Version="4.3.8" />
<PackageManagement Include="Moq" Version="4.20.70" />
<PackageManagement Include="ncrontab" Version="3.3.3" />
<PackageManagement Include="NEST" Version="7.17.5" />
<PackageManagement Include="NJsonSchema" Version="11.0.0" />
<PackageManagement Include="NLog.Web.AspNetCore" Version="5.3.11" />
<PackageManagement Include="NodaTime" Version="3.1.11" />
<PackageManagement Include="OpenIddict.Core" Version="5.6.0" />
<PackageManagement Include="OpenIddict.Server.AspNetCore" Version="5.6.0" />
<PackageManagement Include="OpenIddict.Server.DataProtection" Version="5.6.0" />
<PackageManagement Include="OpenIddict.Validation.AspNetCore" Version="5.6.0" />
<PackageManagement Include="OpenIddict.Validation.DataProtection" Version="5.6.0" />
<PackageManagement Include="OpenIddict.Validation.SystemNetHttp" Version="5.6.0" />
<PackageManagement Include="OrchardCore.Translations.All" Version="1.8.0" />
<PackageManagement Include="PdfPig" Version="0.1.8" />
<PackageManagement Include="Serilog.AspNetCore" Version="8.0.1" />
<PackageManagement Include="Shortcodes" Version="1.3.3" />
<PackageManagement Include="SixLabors.ImageSharp.Web" Version="3.1.2" />
<PackageManagement Include="SixLabors.ImageSharp.Web.Providers.Azure" Version="3.1.2" />
<PackageManagement Include="SixLabors.ImageSharp.Web.Providers.AWS" Version="3.1.2" />
<PackageManagement Include="StackExchange.Redis" Version="2.7.33" />
<PackageManagement Include="StyleCop.Analyzers" Version="1.1.118" />
<PackageManagement Include="System.Linq.Async" Version="6.0.1" />
<PackageManagement Include="System.IO.Hashing" Version="8.0.0" />
<PackageManagement Include="xunit" Version="2.8.1" />
<PackageManagement Include="xunit.analyzers" Version="1.14.0" />
<PackageManagement Include="xunit.runner.visualstudio" Version="2.8.1" />
<PackageManagement Include="YesSql" Version="5.0.0" />
<PackageManagement Include="YesSql.Abstractions" Version="5.0.0" />
<PackageManagement Include="YesSql.Core" Version="5.0.0" />
<PackageManagement Include="YesSql.Filters.Abstractions" Version="5.0.0" />
<PackageManagement Include="YesSql.Filters.Query" Version="5.0.0" />
<PackageManagement Include="ZString" Version="2.6.0" />
<PackageVersion Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="7.5.1" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="MimeKit" Version="4.6.0" />
<PackageVersion Include="MiniProfiler.AspNetCore.Mvc" Version="4.3.8" />
<PackageVersion Include="Moq" Version="4.20.70" />
<PackageVersion Include="ncrontab" Version="3.3.3" />
<PackageVersion Include="NEST" Version="7.17.5" />
<PackageVersion Include="NJsonSchema" Version="11.0.0" />
<PackageVersion Include="NLog.Web.AspNetCore" Version="5.3.11" />
<PackageVersion Include="NodaTime" Version="3.1.11" />
<PackageVersion Include="OpenIddict.Core" Version="5.6.0" />
<PackageVersion Include="OpenIddict.Server.AspNetCore" Version="5.6.0" />
<PackageVersion Include="OpenIddict.Server.DataProtection" Version="5.6.0" />
<PackageVersion Include="OpenIddict.Validation.AspNetCore" Version="5.6.0" />
<PackageVersion Include="OpenIddict.Validation.DataProtection" Version="5.6.0" />
<PackageVersion Include="OpenIddict.Validation.SystemNetHttp" Version="5.6.0" />
<PackageVersion Include="OrchardCore.Translations.All" Version="1.8.0" />
<PackageVersion Include="PdfPig" Version="0.1.8" />
<PackageVersion Include="Serilog.AspNetCore" Version="8.0.1" />
<PackageVersion Include="Shortcodes" Version="1.3.3" />
<PackageVersion Include="SixLabors.ImageSharp.Web" Version="3.1.2" />
<PackageVersion Include="SixLabors.ImageSharp.Web.Providers.Azure" Version="3.1.2" />
<PackageVersion Include="SixLabors.ImageSharp.Web.Providers.AWS" Version="3.1.2" />
<PackageVersion Include="StackExchange.Redis" Version="2.7.33" />
<PackageVersion Include="StyleCop.Analyzers" Version="1.1.118" />
<PackageVersion Include="System.Linq.Async" Version="6.0.1" />
<PackageVersion Include="System.IO.Hashing" Version="8.0.0" />
<PackageVersion Include="xunit" Version="2.8.1" />
<PackageVersion Include="xunit.analyzers" Version="1.14.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.8.1" />
<PackageVersion Include="YesSql" Version="5.0.0" />
<PackageVersion Include="YesSql.Abstractions" Version="5.0.0" />
<PackageVersion Include="YesSql.Core" Version="5.0.0" />
<PackageVersion Include="YesSql.Filters.Abstractions" Version="5.0.0" />
<PackageVersion Include="YesSql.Filters.Query" Version="5.0.0" />
<PackageVersion Include="ZString" Version="2.6.0" />
</ItemGroup>
</Project>
2 changes: 0 additions & 2 deletions src/OrchardCore.Build/OrchardCore.Commons.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<Import Project="Dependencies.props" />

<PropertyGroup>
<LangVersion>12.0</LangVersion>
<VersionPrefix>2.0.0</VersionPrefix>
Expand Down
36 changes: 0 additions & 36 deletions src/OrchardCore.Build/OrchardCore.Commons.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,2 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<Target Name="ApplyPackageManagement" BeforeTargets="CollectPackageReferences" DependsOnTargets="ApplyPackageManagementItems" />

<Target Name="ApplyPackageManagementItems" Inputs="@(PackageManagement)" Outputs="%(PackageManagement.Identity)">
<PropertyGroup>
<_PackageManagementIdentity>%(PackageManagement.Identity)</_PackageManagementIdentity>
<_PackageManagementVersion>%(PackageManagement.Version)</_PackageManagementVersion>
</PropertyGroup>
<Warning Condition=" '%(PackageReference.Identity)' == '$(_PackageManagementIdentity)' and '%(PackageReference.Version)' == '$(_PackageManagementVersion)' "
Code="OC2002"
Text="PackageReference %(PackageReference.Identity)@%(PackageReference.Version) Version attribute is not needed"
File="$(MSBuildProjectFullPath)" />
<ItemGroup>
<PackageReference Condition=" '%(Identity)' == '$(_PackageManagementIdentity)' " Version="$(_PackageManagementVersion)" ManagedVersion="true" />
</ItemGroup>
</Target>

<Target Name="BeforePackageManagement" BeforeTargets="ApplyPackageManagement">
<Message Text="BeforePackageManagement: %(PackageReference.Identity)@%(PackageReference.Version)" Importance="low" />
</Target>

<Target Name="AfterPackageManagement" AfterTargets="ApplyPackageManagement">
<Message Text="AfterPackageManagement: %(PackageReference.Identity)@%(PackageReference.Version)" Importance="low" />

<ItemGroup>
<UnmanagedPackageReference Include="@(PackageReference)" />
<UnmanagedPackageReference Remove="@(UnmanagedPackageReference)" Condition=" '%(UnmanagedPackageReference.ManagedVersion)' == 'true' " />
<UnmanagedPackageReference Remove="@(UnmanagedPackageReference)" Condition=" '%(UnmanagedPackageReference.IsImplicitlyDefined)' == 'true' " />
<UnmanagedPackageReference Remove="@(UnmanagedPackageReference)" Condition=" $([System.String]::Copy('%(Identity)').StartsWith('System.')) " />
</ItemGroup>
<Warning Condition=" '@(UnmanagedPackageReference)' != '' and '%(Identity)' != 'Microsoft.AspNetCore.App' "
Code="OC2003"
Text="%(UnmanagedPackageReference.Identity)@%(UnmanagedPackageReference.Version) is an unmanaged PackageReference"
File="$(MSBuildProjectFullPath)" />
</Target>

</Project>
18 changes: 18 additions & 0 deletions src/OrchardCore.Build/TargetFrameworks.props
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this file to the solution, to the build solution folder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmat can you please address this item so we can merge this PR?

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<Project>
<!-- Default TFMs to use when building and packaging -->
<PropertyGroup>

<!-- TFM used when coding in Visual Studio and when creating templates -->
<!-- All 'template.json' should provide a 'choice' for the default TFM -->
<DefaultTargetFramework>net8.0</DefaultTargetFramework>

<!-- TFMs used to build the abstractions and modules, by convention the default TFM is at the first position -->
<!-- In a cross-targeting build, some assets are only copied on the first TFM, by convention the default TFM -->
<CommonTargetFrameworks Condition="'$(CommonTargetFrameworks)' == ''">net8.0</CommonTargetFrameworks>
</PropertyGroup>

<!-- Detect if the solution is opened in VS to limit the TFMs that are analyzed by Roslyn for performance reasons -->
<PropertyGroup Condition="'$(BuildingInsideVisualStudio)' == 'true' or '$(BuildingByReSharper)' == 'true'">
<CommonTargetFrameworks>$(DefaultTargetFramework)</CommonTargetFrameworks>
</PropertyGroup>
</Project>
MikeAlhayek marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 0 additions & 2 deletions src/OrchardCore.Cms.Web/OrchardCore.Cms.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<Project ToolsVersion="15.0" Sdk="Microsoft.NET.Sdk.Web">

<Import Project="..\OrchardCore.Build\Dependencies.props" />

<!-- Necessary as we reference the Project and not the Package -->
<Import Project="..\OrchardCore\OrchardCore.Application.Cms.Core.Targets\OrchardCore.Application.Cms.Core.Targets.props" />

Expand Down
2 changes: 0 additions & 2 deletions src/OrchardCore.Mvc.Web/OrchardCore.Mvc.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<Project ToolsVersion="15.0" Sdk="Microsoft.NET.Sdk.Web">

<Import Project="..\OrchardCore.Build\Dependencies.props" />

<PropertyGroup>
<TargetFrameworks>$(CommonTargetFrameworks)</TargetFrameworks>
<AspNetCoreHostingModel>InProcess</AspNetCoreHostingModel>
Expand Down
2 changes: 0 additions & 2 deletions src/docs/OrchardCore.Docs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="..\OrchardCore.Build\Dependencies.AspNetCore.props" />

<PropertyGroup>
<TargetFrameworks>$(CommonTargetFrameworks)</TargetFrameworks>
<IsPackable>false</IsPackable>
Expand Down
2 changes: 0 additions & 2 deletions test/OrchardCore.Abstractions.Tests/OrchardCore.Abstractions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="..\..\src\OrchardCore.Build\Dependencies.props" />

<PropertyGroup>
<TargetFrameworks>$(CommonTargetFrameworks)</TargetFrameworks>
<RootNamespace>OrchardCore</RootNamespace>
Expand Down
Loading