-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Central Package Management #16235
Conversation
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. If you like Orchard Core, please star our repo and join our community channels. |
Thank you! Let us know when you're ready for a review. |
@Piedone Ready now. The last commit reverts downgrade of Microsoft.Identity.Web to minimize impact of this change. Transitive pinning is preferred though and can be enabled as a follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good, thank you, but we'll check it together at the triage meeting tomorrow as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this file to the solution, to the build
solution folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmat can you please address this item so we can merge this PR?
This pull request has merge conflicts. Please resolve those before requesting a review. |
When you're done addressing all feedback of a review, please click "Re-request review" in the top-right corner for each reviewer when you're ready for another round of review, so they know that you're done. |
I thought this PR happened because we mentioned it during our meetings last week. But apparently not. |
Co-authored-by: Zoltán Lehóczky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Don't merge before #16235 (comment). |
I moved the version to Directory.Packages.props. I hope this will work, I did it online directly. |
Congratulations on your first PR merge! 🎉 Thank you for your contribution! We're looking forward to welcoming other contributions of yours in the future. @all-contributors please add @tmat for code. If you like Orchard Core, please star our repo and join our community channels. |
@github-actions[bot] I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @tmat! 🎉 |
Thanks! |
Replace custom package management targets with NuGet Central Package Management.
Although the custom
ApplyPackageManagement
target introduced by #1777 works, it causes unnecessary build cache misses under certain circumstances. This in turn degrades Visual Studio build performance.