Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes a reference to options in RequireSettings #16451

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

gvkries
Copy link
Contributor

@gvkries gvkries commented Jul 17, 2024

Removes an unneeded reference to the ResourceManagementOptions in RequireSettings.

/cc @sebastienros

Copy link
Member

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more right since the object can be mutated even if the options aren't.

@Piedone
Copy link
Member

Piedone commented Jul 17, 2024

Is #16401 still fixed?

@gvkries
Copy link
Contributor Author

gvkries commented Jul 17, 2024

It's refactored only, it should not change behavior.

@Piedone
Copy link
Member

Piedone commented Jul 17, 2024

Please do test, because this removes code added by the PR that fixes that issue.

@gvkries
Copy link
Contributor Author

gvkries commented Jul 17, 2024

It just moves the code from the c'tor to the New() method to avoid keeping a reference around. And therefore it also considers changes done to the parent RequireSettings as well.

@gvkries
Copy link
Contributor Author

gvkries commented Jul 17, 2024

So yes, #16401 is still of cause fixed.

@Piedone
Copy link
Member

Piedone commented Jul 17, 2024

OK then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants