Undo binary breaking change

[MikeAlhayek]

Fix #16997

[hishamco]

Where are the binary breaking changes? They are extension methods in the same assembly

[MikeAlhayek]

@hishamco check out the updated description.

[hishamco]

I'm not sure if it's considered as binary breaking-changes while it's an extension methods, so the class name doesn't matter

[hishamco]

Such formatting I told you about previously, and you told me it's done by VS :)

[MikeAlhayek]

I have better things to do that picking on spaces or discussing. sorry

[hishamco]

I'm not sure who this is related to or affects OC. Did you read about binding redirect it might help in your case

[MikeAlhayek]

I'm not sure if it's considered as binary breaking-changes while it's an extension methods, so the class name doesn't matter

We'll it broke me :)

Let say you have Project A on nuget package that use 2.0 assemblies. Also you have project B that uses 2.1-previews and Project A from nuget.

This will give you an exception similar to:

An unhandled exception was thrown by the application. System.TypeLoadException: Could not load type 'OrchardCore.DisplayManagement.Handlers.SiteServiceCollectionExtensions' from assembly 'OrchardCore.DisplayManagement, Version=2.1.0.0, Culture=neutral, PublicKeyToken=null'.

If Project A was complied with 2.1 previews, then this wont be a problem.

[gvkries]

@hishamco Renaming classes is always breaking, in case of extension methods as well if you invoke them directly.

[sebastienros]

I vote for only shipping major versions of Orchard!

[hishamco]

Renaming classes is always breaking, in case of extension methods as well if you invoke them directly.

Agree, but I don't think there's someone invoke them directly otherwise this is not make sense in case of extension methods :)

Again it's a breaking change