Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo binary breaking change #16996

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Undo binary breaking change #16996

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
912f238
Undo binary breaking change
MikeAlhayek Nov 12, 2024
5954f9f
one file
MikeAlhayek Nov 12, 2024
047f45e
new line
MikeAlhayek Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...Management/ServiceCollectionExtensions.cs → ...gement/SiteServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@

namespace OrchardCore.DisplayManagement.Handlers;

public static class ServiceCollectionExtensions
/// <summary>
/// Rename this file to ServiceCollectionExtensions in v3.0.
/// </summary>
public static class SiteServiceCollectionExtensions
{
public static IServiceCollection AddSiteDisplayDriver<TDriver>(this IServiceCollection services)
where TDriver : class, IDisplayDriver<ISite>
=> services.AddDisplayDriver<ISite, TDriver>();
=> services.AddDisplayDriver<ISite, TDriver>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such formatting I told you about previously, and you told me it's done by VS :)

Copy link
Member Author

@MikeAlhayek MikeAlhayek Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have better things to do that picking on spaces or discussing. sorry


public static IServiceCollection AddDisplayDriver<TModel, TDriver>(this IServiceCollection services)
where TDriver : class, IDisplayDriver<TModel>
=> services.AddScoped<IDisplayDriver<TModel>, TDriver>();
where TDriver : class, IDisplayDriver<TModel>
=> services.AddScoped<IDisplayDriver<TModel>, TDriver>();
}