Streamline centalized package version management #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No reason to have extra dll on disk. * Also adds a compile-time target to advise when a project is including an empty build output.
* Adding PackageManagement element automatically overrides matching PackageReference Version attributes * The PackageReference element doesn't need to manually bring in a version property * Provides a build warning if a project directly references a package that doesn't have a matching PackageManagement item
Package management didn't quite work for tool references
* The only remaining Version attributes are for System packages
|
Thanks a lot for this one 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses an ItemGroup instead of a PropertyGroup
Assigns Version attributes automatically when a
<PackageReference Include="X" />matches a<PackageManagement Include="X" />item.The Version attribute is optional at that point. In this PR they are removed.
You don't need to hand-edit csproj Version attributes anymore. If you add a PackageReference that has the wrong version, then that version will be overridden.