-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup & rework many issues introduced by cloud #1100
Conversation
e49fed4
to
d8621a0
Compare
With regards to the filtered rotation commands, the discussion that took place on the previous pull request must not be ignored prior to the decision of whether or not to approve this new PR. It's linked above, I'll link it again. #1094 |
Signed-off-by: Pablete1234 <[email protected]>
d8621a0
to
4167491
Compare
In my eyes the discussion in #1094 already reached a conclusion: it's not worth continuing as the debate has already drained enough time & energy from us all, and it's clear you're not interested in reaching a consensus or proposing any alternatives that could satisfy both parties. Within this pr, it has a solution among many other fixes, if it is accepted, we can finally move forwards and leave it behind. If it is rejected, pgm will have to find a new maintainer. |
Clearly the opinion is not unanimous. I believe that discussion has run its course and there are ample points made by both sides to be considered. Hence, that discussion shouldn't be forgotten due to the change in PR. That doesn't mean it needs to be debated further.
If a certain aspect of a PR is found to need changes, that doesn't mean the entire PR needs to be thrown out. Not sure why it's being posed as an all-or-nothing situation with the other cloud fixes, but that's not how reviews typically work to my understanding. |
Signed-off-by: Pablete1234 <[email protected]>
Signed-off-by: Pablete1234 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working to clean this up, looks good!
Not long ago #1080 was merged, and while it was a step-up some things have been missing, broken, or wrong ever since.
This addresses quite a long list of things in PGM:
/join
which request aJoinMatchModule
or/class
which requestsClassMatchModule
.Team
,PlayerClass
, orMode
./variables [target]
./variables
to paginate by default, allow showing all, and querying for names./mode start <mode> [time]
, now it parses modes by id instead of index in list, and can be autocompleted./rot
commands, they filter by type and have additional help for the user./toggle
commands, they support multiple aliases again, and autocomplete values based on key./pgm
, to reload configs you now use/pgm reload
, that frees-uppgm confirm
andpgm help
, which otherwise just get no-permission errors for default users.Additionally, it switches to a custom cloud fork i've made to fix other issues. The fork source can be found in https://github.com/Pablete1234/Cloud/tree/1.8.0-pgm, it's served from the maven repo https://repo.pgm.fyi/ and includes fixes for:
Audience
could arbitrarily be served aMatch
or aMatchPlayer
Match
andMatchPlayer
implement audience, this has the side-effect of everyone receiving the command output (ie: if the command calls audience.sendMessage on an Audience being implemented by Match), or console not working at all, since it tries to resolve a MatchPlayer to feed as Audience, and ends with a not-a-player error./cycle 0 -f map
do not work/cycle 0 map -f
/vote -o map