Fix double clicking to stack items #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously PGM used SportPaper's InventoryClickedEvent to handle COLLECT_TO_CURSOR, but since it is no longer used in PGM for compatibility reasons, COLLECT_TO_CURSOR should not be ignored as it can cause issues with double clicking to stack items. Signed-off-by: BT (calcastor/mame) <[email protected]>
Electroid
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously PGM used SportPaper's
InventoryClickedEventto handle double clicking to stack items. However, it is no longer used since the introduction of Spigot 1.8 compatibility. Given this,onPlayerClickInventoryshould no longer ignoreCOLLECT_TO_CURSOR. This should resolve issues reported with double clicking to stack items needing more than one double click to work that were reported by players in OCC's most recent tournament.