Amend event priority in ItemTransferListener #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcastor
force-pushed
the
actual-fix-invdc
branch
from
20e7759 to
3dc5fd8
Compare
This reverts commit 9783baf. Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
calcastor
force-pushed
the
actual-fix-invdc
branch
from
3dc5fd8 to
43d1473
Compare
Electroid
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In further testing following #921 being merged I found that this had not actually been the root cause of the problem and caused some unexpected behaviour when sorting from chests into inventory with double clicking to collect stacks. This re-adds
COLLECT_TO_CURSORto the ignored actions for onPlayerClickInventory, and increases the priority of onPlayerInventoryClick's InventoryClickEvent toMONITOR. With this change, double clicking to stack all of a single item from a chest or within a player's own inventory works as would be expected in vanilla Minecraft.