Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow including full files as externals #407

Closed
ghaith opened this issue Dec 7, 2021 · 1 comment · Fixed by #433
Closed

Allow including full files as externals #407

ghaith opened this issue Dec 7, 2021 · 1 comment · Fixed by #433
Assignees
@99NIMI
Labels
enhancement New feature or request libraries
Milestone
Standard function...

Comments

@ghaith
Copy link
Collaborator

ghaith commented Dec 7, 2021

Is your feature request related to a problem? Please describe.
Instead of always defining functions as @external, we should allow the possibility to include an entire file as external so that it is not compiled, but just indexed

Describe the solution you'd like
I propose using a --include and -i parameter for such files

Additional context
Including a file will define all its datatypes, and then define functions and variables as externals.
@ghaith ghaith added enhancement New feature or request libraries labels Dec 7, 2021
@ghaith ghaith added this to the Standard function support milestone Dec 7, 2021
@99NIMI 99NIMI self-assigned this Jan 12, 2022
@create-issue-branch
Copy link

Branch issue-407-Allow_including_full_files_as_externals created!

99NIMI added a commit that referenced this issue Jan 17, 2022
@99NIMI
added --include/-i to cli to include external files (#407)
0547a7e
@99NIMI 99NIMI linked a pull request Jan 17, 2022 that will close this issue
Issue 407 allow including full files as externals #433
Merged
ghaith pushed a commit that referenced this issue Jan 19, 2022
@99NIMI
Issue 407 allow including full files as externals (#433)
0437ecb 
* added --include/-i to cli to include external files (#407)

* added included files to compile-process with external linkage type

* refactor moved parse and index process to own function

* added tests
@ghaith ghaith moved this to Done in Next Jan 9, 2023
@ghaith ghaith added this to Next Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@99NIMI 99NIMI

Labels
enhancement New feature or request libraries
Projects
Next
Status: Done
Milestone
Standard function support
Development

Successfully merging a pull request may close this issue.

Issue 407 allow including full files as externals PLC-lang/rusty
2 participants
@ghaith @99NIMI