-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 407 allow including full files as externals #433
Issue 407 allow including full files as externals #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, i tried the linking locally and it works.
I just have a comment on the method signatures in lib.
kannst du bitte beim commit noch in der commit-msg etwas zusammenfassen, was die zentralen Änderungen waren |
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 93.11% 93.27% +0.16%
==========================================
Files 31 32 +1
Lines 11834 11978 +144
==========================================
+ Hits 11019 11173 +154
+ Misses 815 805 -10
Continue to review full report at Codecov.
|
source files can now be included with "--include", "-i"
functions from included source files can be called like normal functions and must not be declared as @external
included files will be parsed with LinkageType::External and therefore be ignored for codegen