Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 407 allow including full files as externals #433

Merged
merged 7 commits into from
Jan 19, 2022

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Jan 17, 2022

source files can now be included with "--include", "-i"
functions from included source files can be called like normal functions and must not be declared as @external
included files will be parsed with LinkageType::External and therefore be ignored for codegen

@99NIMI 99NIMI linked an issue Jan 17, 2022 that may be closed by this pull request
@99NIMI 99NIMI marked this pull request as draft January 17, 2022 09:15
@99NIMI 99NIMI marked this pull request as ready for review January 17, 2022 10:13
@99NIMI 99NIMI requested a review from ghaith January 17, 2022 10:13
Copy link
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i tried the linking locally and it works.
I just have a comment on the method signatures in lib.

src/cli.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
riederm
riederm previously approved these changes Jan 19, 2022
@riederm
Copy link
Collaborator

riederm commented Jan 19, 2022

kannst du bitte beim commit noch in der commit-msg etwas zusammenfassen, was die zentralen Änderungen waren

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #433 (f813a62) into master (163a0c6) will increase coverage by 0.16%.
The diff coverage is 92.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   93.11%   93.27%   +0.16%     
==========================================
  Files          31       32       +1     
  Lines       11834    11978     +144     
==========================================
+ Hits        11019    11173     +154     
+ Misses        815      805      -10     
Impacted Files Coverage Δ
src/lib.rs 85.23% <85.00%> (-0.18%) ⬇️
src/tests/external_files.rs 98.03% <98.03%> (ø)
src/cli.rs 97.62% <100.00%> (+0.17%) ⬆️
src/parser.rs 98.06% <100.00%> (ø)
src/test_utils.rs 100.00% <100.00%> (ø)
src/tests/multi_files.rs 100.00% <100.00%> (ø)
src/resolver.rs 96.62% <0.00%> (+0.08%) ⬆️
src/codegen/generators/expression_generator.rs 88.49% <0.00%> (+0.56%) ⬆️
src/validation.rs 90.64% <0.00%> (+0.98%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163a0c6...f813a62. Read the comment docs.

@ghaith ghaith merged commit 0437ecb into master Jan 19, 2022
@ghaith ghaith deleted the issue-407-Allow_including_full_files_as_externals branch January 19, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow including full files as externals
4 participants