-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PResult #211
Remove PResult #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 95.93% 95.94%
=======================================
Files 41 41
Lines 15430 15449 +19
=======================================
+ Hits 14803 14822 +19
Misses 627 627
Continue to review full report at Codecov.
|
Ad expression_parser: At this point, |
|
||
pub fn parse_primary_expression(lexer: &mut ParseSession) -> Result<Statement, ParseError> { | ||
/// parse_expression(): returns expression as Statement. if a parse error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, we should try to have more code-documentation for the future!
thx!
This will close #196
This PR will remove all PResults and all unneeded Results from the parser.
The changes that lead to a dead end can be found in PR #202.