-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse 61131-3 Classes #225
Conversation
This reverts commit 0075e0e.
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 93.52% 93.58% +0.06%
==========================================
Files 34 34
Lines 9054 9173 +119
==========================================
+ Hits 8468 8585 +117
- Misses 586 588 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some discussion points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need a test for the FB case. Otherwise this looks good. I'll test it a bit locally though before I give the last approval
What I think might also be good are index tests where we verify instances of a class are initialized correctly, and that we can find methods on classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure if the following tests are correct, but I think so
After this PR, rusty will be able to parse classes. Closes #219. Please merge PR #211 first.
Note that I accidently rebased the changes from PR #211 into this branch (first 10 commits below). Would have been better to merge it... It's going to be squashed anyway, though.
Deviation from the standard: We do not support
VAR_EXTERNAL
constructs since they are rarely used. Namespaces, Inheriting and interface have not been implemented, yet.