Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#353 assigning pointer-address to DWORD and vice versa #388

Merged
merged 3 commits into from
Dec 4, 2021
Merged

#353 assigning pointer-address to DWORD and vice versa #388

merged 3 commits into from
Dec 4, 2021

Conversation

riederm
Copy link
Collaborator

@riederm riederm commented Dec 1, 2021 •
edited
Loading

fixes #353

@riederm riederm force-pushed the issue-353-Pointer-Arithmetic_assigning_a_pointer_s_address_to_a_DWORD branch from 94169a1 to 6cbd06a Compare December 1, 2021 12:25
@riederm riederm changed the title wip #353 assigning pointer-address to DWORD and vice versa Dec 1, 2021
@riederm
Copy link
Collaborator Author

riederm commented Dec 1, 2021 •
edited
Loading

this was rebased onto the ANY-type branch!
there is one failing test that needs to be fixed in that branch

@riederm
fix annotation of adress-of expression
0bc0b11 
adress-of expressions now result in pointer-types that will
be added dynamically to the index

fixes #353
@riederm riederm force-pushed the issue-353-Pointer-Arithmetic_assigning_a_pointer_s_address_to_a_DWORD branch from 21ea30d to 0bc0b11 Compare December 2, 2021 13:58
@riederm riederm requested a review from ghaith December 2, 2021 20:08
ghaith
ghaith previously approved these changes Dec 3, 2021
View reviewed changes
@riederm riederm marked this pull request as ready for review December 3, 2021 15:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021 •
edited
Loading

Codecov Report

Merging #388 (e8b3fdd) into master (8407135) will increase coverage by 0.02%.
The diff coverage is 90.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   93.03%   93.06%   +0.02%     
==========================================
  Files          31       31              
  Lines       10957    11004      +47     
==========================================
+ Hits        10194    10241      +47     
  Misses        763      763
Impacted Files Coverage Δ
src/codegen/llvm_typesystem.rs 77.73% <75.00%> (-0.22%) ⬇️
src/codegen/generators/expression_generator.rs 87.06% <100.00%> (+0.03%) ⬆️
src/codegen/generators/statement_generator.rs 96.75% <100.00%> (+<0.01%) ⬆️
src/resolver.rs 96.07% <100.00%> (+0.07%) ⬆️
src/test_utils.rs 100.00% <100.00%> (ø)
src/validation.rs 90.14% <0.00%> (+0.49%) ⬆️
src/index.rs 97.93% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8407135...e8b3fdd. Read the comment docs.

@riederm riederm force-pushed the issue-353-Pointer-Arithmetic_assigning_a_pointer_s_address_to_a_DWORD branch from 190899e to e8b3fdd Compare December 4, 2021 11:37
@riederm riederm merged commit 8bb7146 into master Dec 4, 2021
@riederm riederm deleted the issue-353-Pointer-Arithmetic_assigning_a_pointer_s_address_to_a_DWORD branch December 4, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghaith ghaith ghaith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pointer-Arithmetic: assigning a pointer's address to a DWORD
3 participants
@riederm @codecov-commenter @ghaith