Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prql-js 0.5.1 release failed #1875

Closed
eitsupi opened this issue Feb 18, 2023 · 4 comments · Fixed by #1887
Closed

prql-js 0.5.1 release failed #1875

eitsupi opened this issue Feb 18, 2023 · 4 comments · Fixed by #1887
Labels

Comments

@eitsupi
Copy link
Member

eitsupi commented Feb 18, 2023

this is what I see in /node_modules after update to prql-js v0.5.1:

image

i.e. no js in that published module. Might need another repackage and publish to npmjs.

Should be more like what we get with prql-js v0.5.0:

image

Originally posted by @RandomFractals in PRQL/prql-vscode#98 (comment)

@eitsupi
Copy link
Member Author

eitsupi commented Feb 18, 2023

Publish log
https://github.com/PRQL/prql/actions/runs/4207097290/jobs/7301452313

npm notice 
npm notice 📦  [email protected]
npm notice === Tarball Contents === 
npm notice 3.6kB README.md             
npm notice 3.6kB dist/bundler/README.md
npm notice 3.6kB dist/node/README.md   
npm notice 3.6kB dist/web/README.md    
npm notice 862B  package.json          
npm notice === Tarball Details === 
npm notice name:          prql-js                                 
npm notice version:       0.5.1                                   
npm notice filename:      prql-js-0.5.1.tgz                       
npm notice package size:  2.0 kB                                  
npm notice unpacked size: 15.4 kB                                 
npm notice shasum:        f94c866938fe66106d4e66959155b427371afd02
npm notice integrity:     sha512-PvFKWEkW0gic6[...]wk2rEThoJQqpQ==
npm notice total files:   5                                       
npm notice 
npm notice Publishing to https://registry.npmjs.org/ with tag latest and default access
+ [email protected]

@RandomFractals
Copy link

I did notice npmjs site had some issues yesterday.

Maybe we should just try to republish it again.

@max-sixty
Copy link
Member

Thanks for spotting and sorry for the inconvenience.

I can't work out what's changed. When I run npm run build, I get the correct tree:

❯ ll -T dist
drwxr-xr-x    - maximilian 14 Jan 11:37 dist/
drwxr-xr-x    - maximilian 18 Feb 09:43 ├── bundler/
.rw-r--r--    1 maximilian 18 Feb 09:43 │  ├── .gitignore
.rw-r--r--  390 maximilian 18 Feb 09:43 │  ├── package.json
.rw-r--r-- 1.2k maximilian 18 Feb 09:43 │  ├── prql_js.d.ts
.rw-r--r--   75 maximilian 18 Feb 09:43 │  ├── prql_js.js
.rw-r--r-- 9.9k maximilian 18 Feb 09:43 │  ├── prql_js_bg.js
.rw-r--r-- 2.9M maximilian 18 Feb 09:43 │  ├── prql_js_bg.wasm
.rw-r--r-- 1.2k maximilian 18 Feb 09:43 │  ├── prql_js_bg.wasm.d.ts
.rw-r--r-- 3.6k maximilian 10 Feb 22:22 │  └── README.md
drwxr-xr-x    - maximilian 18 Feb 09:43 ├── node/
.rw-r--r--    1 maximilian 18 Feb 09:43 │  ├── .gitignore
.rw-r--r--  343 maximilian 18 Feb 09:43 │  ├── package.json
.rw-r--r-- 1.2k maximilian 18 Feb 09:43 │  ├── prql_js.d.ts
.rw-r--r--  10k maximilian 18 Feb 09:43 │  ├── prql_js.js
.rw-r--r-- 2.9M maximilian 18 Feb 09:43 │  ├── prql_js_bg.wasm
.rw-r--r-- 1.2k maximilian 18 Feb 09:43 │  ├── prql_js_bg.wasm.d.ts
.rw-r--r-- 3.6k maximilian 10 Feb 22:22 │  └── README.md
drwxr-xr-x    - maximilian 18 Feb 09:43 └── web/
.rw-r--r--    1 maximilian 18 Feb 09:43    ├── .gitignore
.rw-r--r--  346 maximilian 18 Feb 09:43    ├── package.json
.rw-r--r-- 2.9k maximilian 18 Feb 09:43    ├── prql_js.d.ts
.rw-r--r--  13k maximilian 18 Feb 09:43    ├── prql_js.js
.rw-r--r-- 2.9M maximilian 18 Feb 09:43    ├── prql_js_bg.wasm
.rw-r--r-- 1.2k maximilian 18 Feb 09:43    ├── prql_js_bg.wasm.d.ts
.rw-r--r-- 3.6k maximilian 10 Feb 22:22    └── README.md

...but npm publish doesn't seem to pick them up:

❯ npm publish
npm notice
npm notice 📦  [email protected]
npm notice === Tarball Contents ===
npm notice 3.6kB README.md
npm notice 3.6kB dist/bundler/README.md
npm notice 3.6kB dist/node/README.md
npm notice 3.6kB dist/web/README.md
npm notice 862B  package.json
npm notice === Tarball Details ===
npm notice name:          prql-js
npm notice version:       0.5.1
npm notice filename:      prql-js-0.5.1.tgz
npm notice package size:  2.0 kB
npm notice unpacked size: 15.4 kB
npm notice shasum:        f94c866938fe66106d4e66959155b427371afd02
npm notice integrity:     sha512-PvFKWEkW0gic6[...]wk2rEThoJQqpQ==
npm notice total files:   5
npm notice

@max-sixty
Copy link
Member

FYI I'm out for a few hours. I'll look later, unless anyone else solves the puzzle.

If anyone knows off-hand — is there some way we could have prevented this? e.g. Does node support testing an installed package?

max-sixty added a commit to max-sixty/prql that referenced this issue Feb 19, 2023
Closes PRQL#1875. Not sure why this used to work and doesn't work, but the `.gitignore`s were causing no files to be added to the package. Now we hackily remove them.

This event adds weight to PRQL#1836
max-sixty added a commit that referenced this issue Feb 19, 2023
Closes #1875. Not sure why this used to work and doesn't work, but the `.gitignore`s were causing no files to be added to the package. Now we hackily remove them.

This event adds weight to #1836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants