Skip to content

Commit

Permalink
build(js): Fix wasm-pack's use of .gitignore
Browse files Browse the repository at this point in the history
Closes PRQL#1875. Not sure why this used to work and doesn't work, but the `.gitignore`s were causing no files to be added to the package. Now we hackily remove them.

This event adds weight to PRQL#1836
  • Loading branch information
max-sixty committed Feb 19, 2023
1 parent 4d3a4a2 commit 1160c60
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion prql-js/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,4 +173,4 @@ npm test
[^1]:
Though we would be very open to other approaches, given wasm-pack does not
seem maintained, and we're eliding many of its features to build for three
targets.
targets. See <https://github.com/PRQL/prql/issues/1836> for more details.
6 changes: 3 additions & 3 deletions prql-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
},
"scripts": {
"build": "npm run build:node && npm run build:bundler && npm run build:web",
"build:bundler": "wasm-pack build --target bundler --release --out-dir dist/bundler",
"build:node": "wasm-pack build --target nodejs --release --out-dir dist/node",
"build:web": "wasm-pack build --target no-modules --release --out-dir dist/web",
"build:bundler": "wasm-pack build --target bundler --release --out-dir dist/bundler && rm dist/bundler/.gitignore",
"build:node": "wasm-pack build --target nodejs --release --out-dir dist/node && rm dist/node/.gitignore",
"build:web": "wasm-pack build --target no-modules --release --out-dir dist/web && rm dist/web/.gitignore",
"test": "wasm-pack test --firefox && mocha tests"
},
"types": "dist/node/prql_js.d.ts",
Expand Down

0 comments on commit 1160c60

Please sign in to comment.