Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide mul() function and do not export #109

Closed
AntonReinhard opened this issue Aug 9, 2024 · 0 comments · Fixed by #110
Closed

Hide mul() function and do not export #109

AntonReinhard opened this issue Aug 9, 2024 · 0 comments · Fixed by #110
Labels
05 - Enhancement Improvements of existing code 09 - Maintenance Related to maintenance, housekeeping, repo-config

Comments

@AntonReinhard
Copy link
Member

The mul function in src/interfaces/lorentz_vectors/dirac_interaction.jl currently is exported, but doesn't need to and causes a collision with a mul function in QEDcore.jl. The Base.* function should be enough instead.
@AntonReinhard AntonReinhard added 05 - Enhancement Improvements of existing code 09 - Maintenance Related to maintenance, housekeeping, repo-config labels Aug 9, 2024
@AntonReinhard AntonReinhard mentioned this issue Aug 9, 2024
Merged
AntonReinhard added a commit that referenced this issue Aug 9, 2024
@AntonReinhard
Remove mul from exported functions and rename to _mul (#110)
d36c735 
Fixes #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
05 - Enhancement Improvements of existing code 09 - Maintenance Related to maintenance, housekeeping, repo-config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove mul from exported functions and rename to _mul AntonReinhard/QEDbase.jl
1 participant
@AntonReinhard