Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mul from exported functions and rename to _mul #110

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

AntonReinhard
Copy link
Member

Fixes #109

Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me 👌

AntonReinhard added a commit to QEDjl-project/QEDcore.jl that referenced this pull request Aug 9, 2024
Rename the mul function to _mul since it is not exported.
Goes together with QEDjl-project/QEDbase.jl#110
@AntonReinhard AntonReinhard merged commit d36c735 into QEDjl-project:dev Aug 9, 2024
4 checks passed
@AntonReinhard AntonReinhard added this to the Release-next milestone Aug 9, 2024
@AntonReinhard AntonReinhard deleted the 109-no-export-mul branch August 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide mul() function and do not export
2 participants