Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spin and Polarization Interface for AbstractProcessDefinition #106

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Spin and Polarization Interface for AbstractProcessDefinition #106

merged 5 commits into from
Aug 6, 2024

Conversation

AntonReinhard
Copy link
Member

Adds the functions incoming_spin_pol, outgoing_spin_pol, and spin_pol to the AbstractProcessDefinition interface. These can be implemented by specific processes, or rely on the provided default implementation which returns AllSpin or AllPol for each particle.

Closes #105

@AntonReinhard AntonReinhard requested a review from szabo137 August 6, 2024 09:31
@AntonReinhard AntonReinhard marked this pull request as ready for review August 6, 2024 10:04
@AntonReinhard AntonReinhard added the 06 - Feature-request Missing feature or functionality label Aug 6, 2024
@AntonReinhard AntonReinhard added this to the Release-next milestone Aug 6, 2024
szabo137
szabo137 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! Thanks for providing this! 🙏

@AntonReinhard AntonReinhard merged commit 4082f93 into QEDjl-project:dev Aug 6, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the 105-spin-pol-process branch August 6, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
06 - Feature-request Missing feature or functionality
Projects
None yet
Milestone
Release-0.3.0
Development

Successfully merging this pull request may close these issues.

Extend process interface
2 participants
@AntonReinhard @szabo137