Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Non-Abelian Dihedral Groups Dₘ via Group Presentation ⟨S|R⟩ #397

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 18, 2024

This PR reproduces the Table 3 of the Lin and Pyradko paper: https://arxiv.org/pdf/2306.16400 for non-abelian Dihedral Groups. The structure, order, group identification of Dihedral groups has also been tested along with n, k parameters.

Since Oscar v1.2.0 has not been released yet, Oscar v1.1.1 will throw GAP.jl CI errors because GAP version is v10.4.0. In this version, GAP does not support multi-threaded garbage collection.

All the results from this Table 3 has been reproduced. I think documentation about this will be added in future as well.

Screenshot_select-area_20241018201243

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting. Please do not worry about or address older formatting issues -- keep your PR just focused on your planned contribution.

@Fe-r-oz Fe-r-oz changed the title Non-Abelian Dihedral Groups via Group Presentation Non-Abelian Dihedral Groups via Group Presentation ⟨S|R⟩ Oct 18, 2024
@Fe-r-oz Fe-r-oz changed the title Non-Abelian Dihedral Groups via Group Presentation ⟨S|R⟩ Non-Abelian Dihedral Groups Dₘ via Group Presentation ⟨S|R⟩ Oct 19, 2024
@Fe-r-oz Fe-r-oz changed the title Non-Abelian Dihedral Groups Dₘ via Group Presentation ⟨S|R⟩ tests: Non-Abelian Dihedral Groups Dₘ via Group Presentation ⟨S|R⟩ Oct 22, 2024
@Fe-r-oz Fe-r-oz force-pushed the dihedral branch 2 times, most recently from 3d200c7 to d70148d Compare October 24, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant