Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Semidirect Product Dₘ = Cₘ⋉C₂ of two Cyclic Groups to form Dihedral Group #402

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Oct 23, 2024

This PR reproduces the Table 3 of Lin and Pryadko's paper by using Semidirect product of two cyclic groups instead of group presentation to create non-abelian Dihedral group which was done in: #397

As $D_{m} = C_m \ltimes C_2 = \langle x, s \mid x^m = s^2 = (r*s)^2 = 1 \rangle$, there are two ways to reproduce Table 3:

  1. $C_m \ltimes C_2$ (This PR)
  2. $\langle x, s \mid x^m = s^2 = (r*s)^2 = 1 \rangle$ (done in tests: Non-Abelian Dihedral Groups Dₘ via Group Presentation ⟨S|R⟩ #397)

This PR implements the 1) approach. This first approach was not mentioned in the caption of Table 3 but was referenced in the text of the Appendix. Both gives the same results.

This functionality will also be documented in the future.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them. There will be plenty of old code that is flagged as we are slowly transitioning to enforced formatting.

@Fe-r-oz Fe-r-oz changed the title tests: Semidirect Product Dₘ = Cₘ⋉C₂ of Two Cyclic Groups to form Dihedral Group tests: Semidirect Product Dₘ = Cₘ⋉C₂ of two Cyclic Groups to form Dihedral Group Oct 23, 2024
@Fe-r-oz Fe-r-oz force-pushed the fa/semidirectproduct branch 3 times, most recently from 8eb94f3 to 60ce559 Compare October 24, 2024 07:21
@Fe-r-oz Fe-r-oz force-pushed the fa/semidirectproduct branch from 60ce559 to 3fa8b15 Compare October 24, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant