Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate express functionality and AbstractRepresentation type to QuantumInterface #93

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

apkille
Copy link
Member

@apkille apkille commented Dec 22, 2024

#92 qojulia/QuantumInterface.jl#46
The problem with this PR and the one in QuantumInterface is that a type piracy is introduced here:

express(s, repr::AbstractRepresentation) = express(s, repr, UseAsState())

I suppose we could migrate AbstractUse and its subtypes to QuantumInterface as well, but

function express(state::Symbolic, repr::AbstractRepresentation, use::AbstractUse)

would then be a type piracy. Plus AbstractUse is intended for dealing with edge cases in symbolic-to-Clifford translations, so to me it doesn't make sense to migrate it up to QuantumInterface.

@apkille apkille requested a review from Krastanov December 22, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant