Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate express and AbstractRepresentation type from QuantumSymbolics #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

apkille
Copy link
Contributor

@apkille apkille commented Dec 22, 2024

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 17.04%. Comparing base (3d63b38) to head (fc420c3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/express.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   17.29%   17.04%   -0.26%     
==========================================
  Files          12       13       +1     
  Lines         399      399              
==========================================
- Hits           69       68       -1     
- Misses        330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apkille
Copy link
Contributor Author

apkille commented Dec 22, 2024

Just a note: I moved

express(obj) = express(obj, QuantumOpticsRepr()) # The default representation

to here from QuantumSymbolics to avoid type piracy in QuantumSymbolics. This isn't urgent whatsoever, but I wonder how beneficial it is to have a default representation for express, given that the ecosystem of packages supported by QuantumInterface is growing. This might be a bad comparison, but it's kind of like if DifferentiationInterface were to make its default backend AutoForwardDiff because ForwardDiff.jl has been around a long time and is used by a lot of people. Those things are true and ForwardDiff.jl is quite a handy package, but there's a ton of other autodiff packages that someone might rather use instead. I think the same could be said here. It probably would be a clearer translation interface if the user always has to explicitly define what backend they want to plug into. Of course, this would be a breaking change, but I thought I should put that thought out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant