Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Version Issue #26

Closed
RagipSelcuk opened this issue Aug 6, 2024 · 6 comments
Closed

React Version Issue #26

RagipSelcuk opened this issue Aug 6, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@RagipSelcuk
Copy link
Owner

Cannot Update an unmounted root
In updating the Master branch from the DbcChangeSave feature, React render could not resolve the given .dbc file location.

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:3000/
  2. Click on DbcEditor
  3. Scroll down to 'Open Dbc Raw File'
  4. See the error in the terminal

Expected behavior
Could not open any page depending on the selected.dbc file

Screenshots
2024-08-06T03:19:41.000Z root ERROR Error: Cannot update an unmounted root. at ReactDOMHydrationRoot.render.ReactDOMRoot.render (http://localhost:3000/bundle.js:136518:11) at LocationListRenderer.render (http://localhost:3000/vendors-node_modules_theia_filesystem_lib_browser_file-dialog_file-dialog-service_js.js:2755:23) at OpenFileDialog.onUpdateRequest (http://localhost:3000/vendors-node_modules_theia_filesystem_lib_browser_file-dialog_file-dialog-service_js.js:792:35) at __webpack_modules__.../node_modules/@phosphor/widgets/lib/widget.js.Widget.processMessage (http://localhost:3000/bundle.js:152429:22) at invokeHandler (http://localhost:3000/bundle.js:10917:21) at sendMessage (http://localhost:3000/bundle.js:10653:13) at runMessageLoop (http://localhost:3000/bundle.js:10967:17)

@RagipSelcuk RagipSelcuk added the good first issue Good for newcomers label Aug 6, 2024
@RagipSelcuk
Copy link
Owner Author

RagipSelcuk commented Aug 6, 2024

it seems very similar to this issue eclipse-theia/theia#13454

@didarbilgin
Copy link
Collaborator

For me, when I click ‘Open Dbc Raw File’, I don’t get those errors. The file is created correctly, and the page depending on the newly created file opens just fine. But when I click ‘Open Dbc File’, like you mentioned, the page couldn’t open. However, the error I get is not what you described. I can retrieve the file directory info:

[Info] 2024-08-08T09:38:49.189Z root INFO File dir – "file:///Users/didarnurbilgin/Desktop/CAN_DBC_EL9000B/EL9080-510B.dbc" (bundle.js, line 60234)

But right after that, this is the error I get:

[Error] Unhandled Promise Rejection: Error: A syntax error occurred on line 2 - Reason: Syntax Error at line 1:1. Expected one of '[a-zA-Z_]+_' (anonymous function) (bundle.js:57776)

Have you encountered this error before? I don’t think the error I’m getting is related to the React version or the syntax.

@RagipSelcuk
Copy link
Owner Author

Didar,

I have the same result for 'Open Dbc Raw File.' Unfortunately, I encountered the mentioned issue (OpenFileDialog.onUpdateRequest) after the merge operation. Could you please switch to the main branch and check the result again?

@didarbilgin
Copy link
Collaborator

Even when I switch to the main branch, which is master, I get the same error as before. I don’t understand why we are encountering different errors while being on the same branch.

RagipSelcuk added a commit that referenced this issue Aug 10, 2024
Main issue is related with using of the platfrom general rules.
Proper usage should be as following lines:
* #dbcWidget
* #yarn prepare
* #yarn start:browser

Co-Authored-By: Didar Nur Bilgin <[email protected]>
@RagipSelcuk
Copy link
Owner Author

The main issue is related to using the platform's general rules.
Proper usage should be as follows:

  • #dbcWidget
  • #yarn prepare
  • #yarn start:browser

Please, fetch the main branch. If you have any failure, please don't hesitate to let me know.

@didarbilgin
Copy link
Collaborator

Thank you, I solved the problem. Apparently, the issue was caused by the changes I had made and not committed. When I reverted to the previous version and discarded the changes I made, the problem was resolved. Thank you for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants