Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for disposed before sending update message #13454

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Mar 5, 2024

What it does

fixes #13441

contributed on behalf of STMicroelectronics

How to test

Make sure that the scenario from #13441 does not write error messages to the browser console. It's basically:

  1. Install gitlens
  2. Accept the "workspace trust" dialog
  3. Open two editors.
  4. Hover over the editor toolbar
  5. close all editors.

Follow-ups

Review checklist

Reminder for reviewers

@tsmaeder tsmaeder added the toolbar issues related to the toolbar label Mar 5, 2024
fixes eclipse-theia#13441

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I do not get any error similar to the one on the log.

@tsmaeder tsmaeder merged commit c2b0704 into eclipse-theia:master Mar 22, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolbar issues related to the toolbar
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"Cannot update an unmounted root" from TabBarToolBar
3 participants