fix(ajax): RxJS v6 TimeoutError is missing name property

[bbonnet]

Description:
Update the name property of the AjaxTimeoutError to be "AjaxTimeoutError" instead of "AjaxError".

@felixfbecker mentioned the following in the original issue:

Why not use instanceof? instanceof breaks when multiple RxJS versions are in play, or even just the same version had to be installed multiple times because deduping wasn't possible. It asserts the implementation, err.name asserts an interface. All browser errors use it (e.g. AbortError).

This still will cause problems if the implementation name changes. Open to feedback for a more permanent solution.

Related issue (if exists):
#3602

[coveralls]

Coverage increased (+0.001%) to 96.505% when pulling 44042d0 on bbonnet:fix-timeout-error-name into 7e4cef4 on ReactiveX:master.

[felixfbecker]

Note this doesn't fix #3602, as that uses a different error.

[bbonnet]

Ah I see, that is my mistake. I will look into a better fix that will cover the TimeoutError as well

[bbonnet]

Updated to fix TimeoutError.

Also noticed that some of the tests that are implemented like the following are not hitting some of the expectations:. This test will still pass.

   result.subscribe(() => {
      throw new Error('this should not next');
    }, err => {
      // Never actually getting tested
      expect(err).to.be.an.instanceof(Rx.TimeoutError);
      expect(err.name).to.equal('BlahBlahBlah');
    }, () => {
      throw new Error('this should not complete');
    });

I updated as follows to get the assertions to actually hit. Seen this pattern elsewhere in the tests.

    let error;
    result.subscribe(() => {
      throw new Error('this should not next');
    }, err => {
      error = err;
    }, () => {
      throw new Error('this should not complete');
    });
    rxTestScheduler.flush();
    expect(error).to.be.an.instanceof(Rx.TimeoutError);
    expect(error.name).to.equal('TimeoutError');

[felixfbecker]

did line endings change in this file?

[benlesh]

Thank you, @bbonnet!

[felixfbecker]

it would be nice if this was declared as a property so it is a visible part of the API contract:

public readonly name: 'TimeoutError' = 'TimeoutError'

[bbonnet]

@felixfbecker Following up with that here: #3678