ripme downloading the -mobile.mp4 from redgifs/gfycat #1936
+7,096
−6,142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soloturn
force-pushed
the
main
branch
5 times, most recently
from
41fc473
to
101a608
Compare
|
it looks like you wanted to do the pull reqestion towards https://github.com/ripmeapp2/ripme/pulls ... as normally a pul lrequest has only a couple of commits and yours hee a lot. i tried to cherry-pick your commits to ripme2 therefor ... |
soloturn
force-pushed
the
main
branch
9 times, most recently
from
aeac312
to
368057f
Compare
currently 2 builds happen, one for the main branch, one for the tag. this should not be necessary, one build is sufficient, producing a verison including the git hash. this can be converted to a release later on, and ripme.json updated to this build. the release procedure is thus: first commit, and let it build, second, create a tag like '2.0.4' and mark the release as official, then push an updated ripme.json with the version 2.0.4-12-487e38cc to trigger clients prompting to updating ifself when it is run.
soloturn
force-pushed
the
main
branch
4 times, most recently
from
6a9172e
to
f8f36d2
Compare
java.nio allows to move a file also onto a different filesystem, besides throwing proper error messages.
- increased default retries to 3 (why only 1?) - fixed deprecation message for Motherless ripper
java uses ietf-bcp-47 lanauge tags, which are strings separated by -. resource bundle names are _ separated. porrisavo not fixed, this is a one person artificial dialect from finish cities of pori and savo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
This change is exactly one of the following (please change
[ ]to[x]) to indicate which:Description
Please make the ripper download the full quality mp4 from redgifs/gfycat, instead of the the -mobile.mp4. There's a fork of ripme here that does download the correct version. It was linked on another bug report of the mobile mp4 issue, here
Testing
Required verification:
mvn test(there are no new failures or errors) <--- not sure what this means, sorryThat fork of ripme does work for the -mobile mp4 issue, but it's as you can see quite a bit older (1.7.97 compared to your 2.0.1), so probably just want to take the bit that works and discard the rest, I guess.
Hope I did this pull request vaguely correctly man, I'm sorry if I messed it up, it's my first time doing this.