-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: text hmi and implement hmi task as ros2 action #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmajek
force-pushed
the
refactor/hmi
branch
from
September 2, 2024 12:47
82f2aca
to
8573743
Compare
boczekbartek
force-pushed
the
bb/task_as_action
branch
from
September 3, 2024 08:04
4f3a00b
to
f8af92a
Compare
Signed-off-by: Bartłomiej Boczek <[email protected]>
boczekbartek
force-pushed
the
bb/task_as_action
branch
from
September 3, 2024 08:17
f8af92a
to
71cb1e0
Compare
boczekbartek
force-pushed
the
bb/task_as_action
branch
from
September 4, 2024 11:45
67920dd
to
bab67e9
Compare
maciejmajek
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. I've tested using the provided instructions and it works as intended. Great job
boczekbartek
changed the title
refactor: text hmi
refactor: text hmi and implement hmi task as ros2 action
Sep 6, 2024
Closed
maciejmajek
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Bartłomiej Boczek <[email protected]>
maciejmajek
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: Bartłomiej Boczek <[email protected]>
maciejmajek
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Bartłomiej Boczek <[email protected]>
boczekbartek
added a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Bartłomiej Boczek <[email protected]>
maciejmajek
pushed a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Bartłomiej Boczek <[email protected]>
maciejmajek
pushed a commit
that referenced
this pull request
Sep 18, 2024
Signed-off-by: Bartłomiej Boczek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First merge: #188
Purpose
ros2 action
Proposed Changes
TODOs (out of scope of this PR):
text_hmi
): toggle old messages in history #205rai_node
Issues
Testing
Implementation was tested using RosbotXL demo
rai_whoami_node
Terminal 1 - streamlit app:
. ./setup_shell.sh streamlit run src/rai_hmi/rai_hmi/text_hmi.py rosbot_xl_whoami
Terminal 2 - whoami:
Terminal 3 - simple ros2 action server for testing
mock_rai_node.py
. ./setup_shell.sh python3 mock_rai_node.py