Document potential wrong-usage of context/dynamic nodes #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandra-simeonova
requested review from
hardl,
JohannesDoberer,
marynaKhromova,
maxmarkus,
pekura and
zarkosimic
as code owners
hardl
reviewed
Mar 20, 2020
docs/navigation-advanced.md
Outdated
| @@ -98,7 +98,7 @@ navigation: { | |||
| ### Dynamic viewUrl parameters | |||
|
|
|||
| You have the following options to add a parameter to **viewUrl**: | |||
| - Place the parameter anywhere in the **viewUrl** value. For example, if the main application URL is `https://[YOUR.WEBSITE]/home/users/JohnSmith`, then the **viewUrl** of the micro frontend in the content area can be `https://example.com/users/details.html#id=JohnSmith`. | |||
| - Place the parameter anywhere in the **viewUrl** value. For example, if the main application URL is `https://[YOUR.WEBSITE]/home/users/:id`, then the **viewUrl** of the micro frontend in the content area can be `https://example.com/users.html#id=JohnSmith`. | |||
There was a problem hiding this comment.
this change is a bit confusing, since it removes the link between main app route and mf url. Should be either JohnSmith as before or ':id' on BOTH URLs. If you choose :id, add additional info that this is then replaced by a real value, e.g. JohnSmith
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Mar 25, 2020
* master: Document potential wrong-usage of context/dynamic nodes (SAP#1155) travis fix version upate to v0.7.7 (SAP#1186) Revert fallbackFrame okResponseHandler (SAP#1183) # Conflicts: # .travis.yml # client/luigi-client.d.ts # client/package-lock.json # client/package.json # client/public/package.json # core/package-lock.json # core/package.json # core/public/package.json # test/e2e-test-application/package-lock.json
JohannesDoberer
added a commit
that referenced
this pull request
Mar 25, 2020
* master: (37 commits) Update deps to 0.7.7 (#1193) Document potential wrong-usage of context/dynamic nodes (#1155) travis fix version upate to v0.7.7 (#1186) Revert fallbackFrame okResponseHandler (#1183) fix virtualTree to not add trailing slash at viewUrl (#1172) Fix navigate ok check (#1179) remove docsearch (#1178) Recalculation after cache deletion (#1173) Luigi Videos (#1060) Add hint to core functionality called early (#1130) Add implementations/scenarios (#1116) deleteCache was missing in contextswitcher (#1148) Update type descriptions (#1131) Route change loses context in contextswitcher (#1145) Debug cypress travis - parallel e2e tests (#1121) trying to run npm step only if triggered or pushed to master (#1139) Release v0.7.6 revert docs fiddle (#1138) travis fix travis fix ... # Conflicts: # .travis.yml # CHANGELOG.md # client/luigi-client.d.ts # client/package-lock.json # client/package.json # client/public/package.json # client/src/linkManager.js # core/examples/luigi-sample-angular/src/assets/sampleexternal.html # core/package-lock.json # core/package.json # core/public/package.json # core/src/core-api/_internalLinkManager.js # core/src/core-api/baseClass.js # core/src/main.js # core/src/navigation/TopNav.html # docs/application-setup.md # docs/getting-started.md # docs/luigi-client-api.md # lerna.json # plugins/auth/src/auth-oidc/index.js # scripts/setup/angular.sh # scripts/setup/no-framework.sh # scripts/setup/openui5.sh # scripts/setup/vue.sh # test/e2e-test-application/e2e/tests/1-angular/navigation.spec.js # test/e2e-test-application/package-lock.json # test/e2e-test-application/package.json # test/e2e-test-application/src/app/project/dynamic/dynamic.component.ts # test/e2e-test-application/src/luigi-config/extended/auth.js # website/docs/package-lock.json # website/docs/package.json # website/fiddle/package.json
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Apr 14, 2020
* master: Release v1 (SAP#1201) Update deps to 0.7.7 (SAP#1193) Document potential wrong-usage of context/dynamic nodes (SAP#1155) travis fix version upate to v0.7.7 (SAP#1186) Revert fallbackFrame okResponseHandler (SAP#1183) fix virtualTree to not add trailing slash at viewUrl (SAP#1172) Fix navigate ok check (SAP#1179) remove docsearch (SAP#1178) Recalculation after cache deletion (SAP#1173) Luigi Videos (SAP#1060) Add hint to core functionality called early (SAP#1130) Add implementations/scenarios (SAP#1116) deleteCache was missing in contextswitcher (SAP#1148) Update type descriptions (SAP#1131) Route change loses context in contextswitcher (SAP#1145) Debug cypress travis - parallel e2e tests (SAP#1121)
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#1133